-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Remove other pandas.core.index files from MyPy Blacklist #26315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26315 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52291 52291
==========================================
- Hits 48132 48128 -4
- Misses 4159 4163 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26315 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52291 52291
==========================================
- Hits 48132 48128 -4
- Misses 4159 4163 +4
Continue to review full report at Codecov.
|
@@ -264,7 +264,7 @@ def __new__(cls, data=None, dtype=None, copy=False, name=None, | |||
if fastpath: | |||
return cls._simple_new(data, name) | |||
|
|||
from .range import RangeIndex | |||
from pandas import RangeIndex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you convert these to absolute references rather than pulling from the top level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ok, we do this all over the place
can you merge master |
git diff upstream/master -u -- "*.py" | flake8 --diff