Skip to content

Remove other pandas.core.index files from MyPy Blacklist #26315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

makbigc
Copy link
Contributor

@makbigc makbigc commented May 8, 2019

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #26315 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26315      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52291    52291              
==========================================
- Hits        48132    48128       -4     
- Misses       4159     4163       +4
Flag Coverage Δ
#multiple 90.59% <100%> (ø) ⬆️
#single 40.74% <62.5%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.72% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b6115...290e275. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #26315 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26315      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52291    52291              
==========================================
- Hits        48132    48128       -4     
- Misses       4159     4163       +4
Flag Coverage Δ
#multiple 90.59% <100%> (ø) ⬆️
#single 40.74% <62.5%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.72% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b6115...290e275. Read the comment docs.

@@ -264,7 +264,7 @@ def __new__(cls, data=None, dtype=None, copy=False, name=None,
if fastpath:
return cls._simple_new(data, name)

from .range import RangeIndex
from pandas import RangeIndex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you convert these to absolute references rather than pulling from the top level?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ok, we do this all over the place

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label May 8, 2019
@jreback jreback added this to the 0.25.0 milestone May 11, 2019
@jreback
Copy link
Contributor

jreback commented May 12, 2019

can you merge master

@makbigc makbigc closed this May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants