CLN: clean more uses of python2-style super() #26261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
commented
May 1, 2019
| @@ -6336,8 +6336,7 @@ def _aggregate(self, arg, axis=0, *args, **kwargs): | |||
| if axis == 1: | |||
| # NDFrame.aggregate returns a tuple, and we need to transpose | |||
| # only result | |||
| result, how = (super(DataFrame, self.T) | |||
| ._aggregate(arg, *args, **kwargs)) | |||
| result, how = self.T._aggregate(arg, *args, **kwargs) | |||
There was a problem hiding this comment.
This is more readable IMO.
topper-123
commented
May 1, 2019
| @@ -6348,7 +6347,7 @@ def _aggregate(self, arg, axis=0, *args, **kwargs): | |||
| def transform(self, func, axis=0, *args, **kwargs): | |||
| axis = self._get_axis_number(axis) | |||
| if axis == 1: | |||
| return super(DataFrame, self.T).transform(func, *args, **kwargs).T | |||
| return self.T.transform(func, *args, **kwargs).T | |||
There was a problem hiding this comment.
This is more readable IMO.
Codecov Report
@@ Coverage Diff @@
## master #26261 +/- ##
==========================================
- Coverage 91.97% 91.97% -0.01%
==========================================
Files 175 175
Lines 52386 52386
==========================================
- Hits 48184 48181 -3
- Misses 4202 4205 +3
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26261 +/- ##
==========================================
- Coverage 91.97% 91.97% -0.01%
==========================================
Files 175 175
Lines 52386 52386
==========================================
- Hits 48184 48181 -3
- Misses 4202 4205 +3
Continue to review full report at Codecov.
|
|
thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the uses of
superby converting to use python3 idioms. This is a followup to #26177, focusing on uses ofsuperin class methods.Also adds a check for python2-style uses of
superin code_checks.sh.