-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Test doctests in pandas/core/groupby/groupby.py #26255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26255 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.01%
==========================================
Files 175 175
Lines 52384 52384
==========================================
- Hits 48184 48179 -5
- Misses 4200 4205 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26255 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.02%
==========================================
Files 175 175
Lines 52384 52386 +2
==========================================
- Hits 48184 48180 -4
- Misses 4200 4206 +6
Continue to review full report at Codecov.
|
this is probably a good fix, but we are not testing this currently, you need update in ci/code_checks (and see if this passes)
|
Thanks for your guidance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Feel free to fix the doctests in cumcount, describe, pipe in this PR if you want. But happy to merge this and take care of them later.
thanks for the patch @HyukjinKwon keep em coming! |
git diff upstream/master -u -- "*.py" | flake8 --diff