Skip to content

BUG: Enable plotting with PeriodIndex with arbitrary frequencies, resolves #14763 #26241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 28, 2019
Merged

BUG: Enable plotting with PeriodIndex with arbitrary frequencies, resolves #14763 #26241

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a14edfe
BUG: Enable plotting with PeriodIndex with arbitrary frequencies, res…
JoElfner Apr 29, 2019
53441fe
Added tests for arbitrary freqs
JoElfner Apr 29, 2019
21b5e1f
Adapt existing tests for arbitrary freq PeriodIndex, args formatting …
JoElfner Apr 30, 2019
be49874
test_tsplot updated
JoElfner Apr 30, 2019
688d3e5
test_tsplot updated
JoElfner Apr 30, 2019
dbd95fc
test_tsplot updated
JoElfner Apr 30, 2019
375a137
reverted existing tests, created new
JoElfner Apr 30, 2019
5236468
tests modified to be keep it self-contained
JoElfner May 17, 2019
8466a85
unused itertools import removed
JoElfner May 17, 2019
b9457b6
release note added in 0.25.0.rst
JoElfner May 17, 2019
5182611
release note conflicts resolved
JoElfner May 17, 2019
61aa357
release note conflicts resolved
JoElfner May 17, 2019
6f31b73
release note conflicts resolved
JoElfner May 17, 2019
4114066
added issue number as comment to tests. class PeriodIndex added to wh…
JoElfner May 23, 2019
bd09ff4
tests parametrized
JoElfner May 27, 2019
0370300
tests parametrized
JoElfner May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pandas/plotting/_timeseries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def _get_index_freq(data):
def _maybe_convert_index(ax, data):
# tsplot converts automatically, but don't want to convert index
# over and over for DataFrames
if isinstance(data.index, ABCDatetimeIndex):
if isinstance(data.index, (ABCDatetimeIndex, ABCPeriodIndex)):
freq = getattr(data.index, 'freq', None)

if freq is None:
Expand All @@ -279,7 +279,10 @@ def _maybe_convert_index(ax, data):
freq = get_base_alias(freq)
freq = frequencies.get_period_alias(freq)

data = data.to_period(freq=freq)
if isinstance(data.index, ABCDatetimeIndex):
data = data.to_period(freq=freq)
elif isinstance(data.index, ABCPeriodIndex):
data.index = data.index.asfreq(freq)
return data


Expand Down