-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Test pd.Grouper base floating point error (#25161) #26240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create this as a separate test? The existing one you are appending to is rather large as is
Codecov Report
@@ Coverage Diff @@
## master #26240 +/- ##
==========================================
- Coverage 91.97% 91.96% -0.01%
==========================================
Files 175 175
Lines 52368 52368
==========================================
- Hits 48164 48161 -3
- Misses 4204 4207 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26240 +/- ##
==========================================
+ Coverage 91.97% 91.97% +<.01%
==========================================
Files 175 175
Lines 52368 52386 +18
==========================================
+ Hits 48164 48181 +17
- Misses 4204 4205 +1
Continue to review full report at Codecov.
|
@@ -303,6 +303,18 @@ def test_grouper_getting_correct_binner(self): | |||
def test_grouper_iter(self, df): | |||
assert sorted(df.groupby('A').grouper) == ['bar', 'foo'] | |||
|
|||
def test_grouper_base(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move to test pandas/tests/resample/test_timegrouper and also test in .resample (which is what this calls)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it
Use resample() which is what Grouper calls, assert index instead of result of size()
thanks @ihsansecer |
git diff upstream/master -u -- "*.py" | flake8 --diff