CLN: Remove unnecessary io function returns #26238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions return a function either with empty return statement or doesn’t return. It causes docstring validation error with type RT01 (See pandas-dev#26234).
Codecov Report
@@ Coverage Diff @@
## master #26238 +/- ##
==========================================
- Coverage 91.97% 91.96% -0.01%
==========================================
Files 175 175
Lines 52368 52368
==========================================
- Hits 48164 48161 -3
- Misses 4204 4207 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26238 +/- ##
==========================================
- Coverage 91.97% 91.96% -0.01%
==========================================
Files 175 175
Lines 52368 52368
==========================================
- Hits 48164 48160 -4
- Misses 4204 4208 +4
Continue to review full report at Codecov.
|
WillAyd
requested changes
Apr 29, 2019
WillAyd
approved these changes
Apr 30, 2019
|
thanks @ihsansecer |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions return a function either with empty return statement or doesn’t return. It causes docstring validation error with type RT01 (See #26234).
git diff upstream/master -u -- "*.py" | flake8 --diff