CLN: Remove inheritance from object in pyx-files #26217
Conversation
| @@ -141,7 +141,7 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then | |||
| RET=$(($RET + $?)) ; echo $MSG "DONE" | |||
|
|
|||
| MSG='Check for python2 new-style classes' ; echo $MSG | |||
| invgrep -R --include="*.py" -E "class\s\S*\(object\):" pandas scripts | |||
| invgrep -R --include="*.py" --include="*.pyx" -E "class\s\S*\(object\):" pandas scripts | |||
There was a problem hiding this comment.
Would make sense to just have one include flag like in the other PR
There was a problem hiding this comment.
This follows the conventions of the code_checks.sh file. I also find it more readable than the other convention...
Codecov Report
@@ Coverage Diff @@
## master #26217 +/- ##
==========================================
- Coverage 91.97% 91.97% -0.01%
==========================================
Files 175 175
Lines 52379 52379
==========================================
- Hits 48178 48174 -4
- Misses 4201 4205 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26217 +/- ##
==========================================
- Coverage 91.97% 91.97% -0.01%
==========================================
Files 175 175
Lines 52379 52379
==========================================
- Hits 48178 48174 -4
- Misses 4201 4205 +4
Continue to review full report at Codecov.
|
|
Thanks @topper-123 ! |
Continuation of #26128, this time dealing with pyx-files.