-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: remove python2 file encodings #26196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e32e672
to
1d373fb
Compare
1d373fb
to
2da1c2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK by me. For Cython it looks like default is UTF8 as well:
http://docs.cython.org/en/latest/src/tutorial/strings.html#source-code-encoding
Should be OK to remove from any file ending in .pyx or .pxi.in
@@ -1,4 +1,3 @@ | |||
# -*- coding: utf-8 -*- | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth deleting leading whitespace (applicable in a few modules)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, slightly confusing comment coming:
I saw that just after pushing, and was working with -# coding=utf-8
at the time, so I changed this PR to deal with that (including dealing with whitespace).
Codecov Report
@@ Coverage Diff @@
## master #26196 +/- ##
==========================================
- Coverage 91.98% 91.98% -0.01%
==========================================
Files 175 175
Lines 52372 52365 -7
==========================================
- Hits 48176 48166 -10
- Misses 4196 4199 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26196 +/- ##
==========================================
- Coverage 91.98% 91.98% -0.01%
==========================================
Files 175 175
Lines 52372 52372
==========================================
- Hits 48176 48172 -4
- Misses 4196 4200 +4
Continue to review full report at Codecov.
|
thanks @topper-123 |
Remove usage of
# coding=utf-8
pattern from code base.