Skip to content

CLN: remove python2 file encodings #26196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Apr 23, 2019

Remove usage of # coding=utf-8 pattern from code base.

@topper-123 topper-123 force-pushed the remove_file_encoding branch from e32e672 to 1d373fb Compare April 23, 2019 17:42
@topper-123 topper-123 force-pushed the remove_file_encoding branch from 1d373fb to 2da1c2a Compare April 23, 2019 17:52
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me. For Cython it looks like default is UTF8 as well:

http://docs.cython.org/en/latest/src/tutorial/strings.html#source-code-encoding

Should be OK to remove from any file ending in .pyx or .pxi.in

@@ -1,4 +1,3 @@
# -*- coding: utf-8 -*-

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth deleting leading whitespace (applicable in a few modules)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, slightly confusing comment coming:

I saw that just after pushing, and was working with -# coding=utf-8 at the time, so I changed this PR to deal with that (including dealing with whitespace).

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26196 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26196      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52372    52365       -7     
==========================================
- Hits        48176    48166      -10     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.53% <ø> (-0.01%) ⬇️
#single 40.69% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/core/strings.py 98.86% <ø> (ø) ⬆️
pandas/io/formats/format.py 97.9% <ø> (-0.01%) ⬇️
pandas/core/accessor.py 98.79% <ø> (-0.02%) ⬇️
pandas/io/formats/csvs.py 98.19% <ø> (-0.02%) ⬇️
pandas/core/internals/blocks.py 94.08% <ø> (ø) ⬆️
pandas/_libs/__init__.py 100% <ø> (ø) ⬆️
pandas/core/internals/concat.py 96.48% <ø> (ø) ⬆️
pandas/_libs/tslibs/__init__.py 100% <ø> (ø) ⬆️
pandas/core/arrays/period.py 98.53% <ø> (ø) ⬆️
pandas/io/formats/html.py 99.36% <ø> (-0.01%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74901b...2da1c2a. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26196 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26196      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52372    52372              
==========================================
- Hits        48176    48172       -4     
- Misses       4196     4200       +4
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74901b...2da1c2a. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Apr 24, 2019
@jreback jreback merged commit d41c1da into pandas-dev:master Apr 24, 2019
@jreback
Copy link
Contributor

jreback commented Apr 24, 2019

thanks @topper-123

@topper-123 topper-123 deleted the remove_file_encoding branch May 5, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants