Skip to content

TST: Remove bare pytest.raises in some test files #26193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 23, 2019

No description provided.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Code Style Code style, linting, code_checks labels Apr 23, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone Apr 23, 2019
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26193 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26193      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52370    52370              
==========================================
- Hits        48174    48170       -4     
- Misses       4196     4200       +4
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.71% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e46ad...2e5ab40. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26193 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26193      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52370    52370              
==========================================
- Hits        48174    48170       -4     
- Misses       4196     4200       +4
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.71% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e46ad...2e5ab40. Read the comment docs.

@jreback jreback merged commit d74901b into pandas-dev:master Apr 23, 2019
@jreback
Copy link
Contributor

jreback commented Apr 23, 2019

thanks @gfyoung

do we have a code check for this? not sure if its easy to catch

@gfyoung
Copy link
Member Author

gfyoung commented Apr 23, 2019

@jreback : Not yet, as there are still a to of places where we use this construct. Slowly going through these when I (and other contributors) can.

@gfyoung gfyoung deleted the bare-pytest-raises-remove branch April 24, 2019 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants