Skip to content

xref #26189, xfail scipy interpolate test for pchip with timedelta #26190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2019
Merged

xref #26189, xfail scipy interpolate test for pchip with timedelta #26190

merged 1 commit into from
Apr 23, 2019

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 22, 2019

xref #26189

@jreback jreback added Testing pandas testing functions or related to the test suite Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Apr 22, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 22, 2019
@jreback jreback mentioned this pull request Apr 22, 2019
Closed
@jreback
Copy link
Contributor Author

jreback commented Apr 22, 2019

cc @WillAyd this should over the failing numpy-dev build issue

@WillAyd
Copy link
Member

WillAyd commented Apr 23, 2019

Makes sense. lgtm if green

@jreback
Copy link
Contributor Author

jreback commented Apr 23, 2019

this will still fail on the doc-string validation issue (your PR is fixing)

@WillAyd
Copy link
Member

WillAyd commented Apr 23, 2019

Yea meant excluding that. Looks like there's something else I need to fix in that PR so feel free to merge this in advance

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26190 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26190      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52371    52371              
==========================================
- Hits        48175    48172       -3     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.71% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecee8f...ac6b7c6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 23, 2019 •
edited
Loading

Codecov Report

Merging #26190 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26190      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52371    52371              
==========================================
- Hits        48175    48172       -3     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.71% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecee8f...ac6b7c6. Read the comment docs.

@jreback jreback merged commit e134ddb into pandas-dev:master Apr 23, 2019
jreback added a commit to jreback/pandas that referenced this pull request Apr 28, 2019
@jreback
Revert "xref pandas-dev#26189, xfail scipy interpolate test for pchip…
d70a722 
… with timedelta (pandas-dev#26190)"

This reverts commit e134ddb.
jreback added a commit that referenced this pull request Apr 28, 2019
@jreback
Revert "xref #26189, xfail scipy interpolate test for pchip with time…
310a7e3 
…delta (#26190)" (#26231)

This reverts commit e134ddb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jreback @WillAyd