Fixed code issue from compat with new numpydoc #26188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
added
Docs
CI
jreback
reviewed
Apr 22, 2019
scripts/validate_docstrings.py
Outdated
| @@ -473,8 +473,7 @@ def parameter_desc(self, param): | |||
| @property | |||
| def see_also(self): | |||
| return collections.OrderedDict((name, ''.join(desc)) | |||
| for name, desc, _ | |||
| in self.doc['See Also']) | |||
| for name, desc in self.doc['See Also']) | |||
There was a problem hiding this comment.
prob want to put a numpydoc>=0.9.0 in environment.yml
alt you might be able to
for name, desc, * in self.doc[....]
Codecov Report
@@ Coverage Diff @@
## master #26188 +/- ##
===========================================
- Coverage 91.98% 40.71% -51.28%
===========================================
Files 175 175
Lines 52371 52371
===========================================
- Hits 48175 21321 -26854
- Misses 4196 31050 +26854
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26188 +/- ##
==========================================
- Coverage 91.98% 91.98% -0.01%
==========================================
Files 175 175
Lines 52371 52371
==========================================
- Hits 48175 48172 -3
- Misses 4196 4199 +3
Continue to review full report at Codecov.
|
jreback
reviewed
Apr 23, 2019
| for name, desc, _ | ||
| in self.doc['See Also']) | ||
| result = collections.OrderedDict() | ||
| for funcs, desc in self.doc['See Also']: |
There was a problem hiding this comment.
could write this as a list comprehension but not a big deal
|
Hmm, this seemed to rely on some |
jorisvandenbossche
approved these changes
Apr 23, 2019
|
thanks @WillAyd |
anmyachev
pushed a commit
to anmyachev/pandas
that referenced
this pull request
Apr 24, 2019
anmyachev
added a commit
to anmyachev/pandas
that referenced
this pull request
Apr 24, 2019
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) * TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778 added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without) fixed lint error Fixed code issue from compat with new numpydoc (pandas-dev#26188) fixed docstring
anmyachev
added a commit
to anmyachev/pandas
that referenced
this pull request
Apr 25, 2019
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) * TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778 added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without) fixed lint error Fixed code issue from compat with new numpydoc (pandas-dev#26188) fixed docstring
anmyachev
added a commit
to anmyachev/pandas
that referenced
this pull request
Apr 25, 2019
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) * TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778 added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without) fixed lint error Fixed code issue from compat with new numpydoc (pandas-dev#26188) fixed docstring
anmyachev
added a commit
to anmyachev/pandas
that referenced
this pull request
Apr 25, 2019
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) * TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778 added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without) fixed lint error Fixed code issue from compat with new numpydoc (pandas-dev#26188) fixed docstring
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff