Skip to content

CLN: remove util._doctools._WritableDoc #26164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2019

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Apr 20, 2019

Removes the metaclass _WritableDoc from the code base.

@jreback jreback added this to the 0.25.0 milestone Apr 20, 2019
@jreback
Copy link
Contributor

jreback commented Apr 20, 2019

lgtm. ping on green.

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #26164 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26164      +/-   ##
==========================================
- Coverage      92%   91.97%   -0.03%     
==========================================
  Files         175      175              
  Lines       52382    52374       -8     
==========================================
- Hits        48195    48173      -22     
- Misses       4187     4201      +14
Flag Coverage Δ
#multiple 90.53% <ø> (-0.03%) ⬇️
#single 40.72% <ø> (-0.17%) ⬇️
Impacted Files Coverage Δ
pandas/util/_doctools.py 0% <ø> (-12%) ⬇️
pandas/core/arrays/interval.py 93.06% <ø> (-0.06%) ⬇️
pandas/core/indexes/interval.py 95.22% <ø> (-0.03%) ⬇️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e90d43...09a5065. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #26164 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26164      +/-   ##
==========================================
- Coverage      92%   91.97%   -0.03%     
==========================================
  Files         175      175              
  Lines       52382    52374       -8     
==========================================
- Hits        48195    48173      -22     
- Misses       4187     4201      +14
Flag Coverage Δ
#multiple 90.53% <ø> (-0.03%) ⬇️
#single 40.72% <ø> (-0.17%) ⬇️
Impacted Files Coverage Δ
pandas/util/_doctools.py 0% <ø> (-12%) ⬇️
pandas/core/arrays/interval.py 93.06% <ø> (-0.06%) ⬇️
pandas/core/indexes/interval.py 95.22% <ø> (-0.03%) ⬇️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e90d43...09a5065. Read the comment docs.

@topper-123
Copy link
Contributor Author

Green.

@jreback jreback merged commit dc86509 into pandas-dev:master Apr 20, 2019
@jreback
Copy link
Contributor

jreback commented Apr 20, 2019

thanks @topper-123

@topper-123 topper-123 deleted the remove_doctools._WritableDoc branch April 20, 2019 18:45
yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
ryanreh99 pushed a commit to ryanreh99/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants