Skip to content

CLN: replace %s syntax with .format in pandas.core.indexes #26159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

makeajourney
Copy link
Contributor

progress towards #16130

  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #26159 into master will decrease coverage by 51.25%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26159       +/-   ##
===========================================
- Coverage      92%   40.74%   -51.26%     
===========================================
  Files         175      175               
  Lines       52371    52371               
===========================================
- Hits        48184    21340    -26844     
- Misses       4187    31031    +26844
Flag Coverage Δ
#multiple ?
#single 40.74% <25%> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 33.92% <0%> (-61.69%) ⬇️
pandas/core/indexes/frozen.py 61.84% <0%> (-30.27%) ⬇️
pandas/core/indexes/base.py 55.55% <40%> (-41.44%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79b7bb...8fb34f7. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #26159 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26159      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52372    52372              
==========================================
- Hits        48176    48173       -3     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.53% <100%> (ø) ⬆️
#single 40.7% <25%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 95.61% <100%> (ø) ⬆️
pandas/core/indexes/frozen.py 92.1% <100%> (ø) ⬆️
pandas/core/indexes/base.py 96.99% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.71% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74901b...642dfbe. Read the comment docs.

@gfyoung gfyoung added the Clean label Apr 20, 2019
@jreback jreback modified the milestone: 0.25.0 Apr 20, 2019
@jreback
Copy link
Contributor

jreback commented Apr 20, 2019

this has some failures (ignore the 3.7 numpy_dev ones for now), but the others are legit

@jreback
Copy link
Contributor

jreback commented Apr 23, 2019

can you merge master

@makeajourney makeajourney force-pushed the issue-16130-core-indexes branch from 8fb34f7 to 642dfbe Compare April 23, 2019 13:18
return "%s(%s)" % (self.__class__.__name__,
str(self))
return "{class_name}({list!s})".format(
class_name=self.__class__.__name__, list=self)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use a kwarg other than list here to avoid overlap with builtin name

@jreback
Copy link
Contributor

jreback commented May 7, 2019

closing as stale; ping if you want to continue

@jreback jreback closed this May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants