-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: replace %s syntax with .format in pandas.core.indexes #26159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: replace %s syntax with .format in pandas.core.indexes #26159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26159 +/- ##
===========================================
- Coverage 92% 40.74% -51.26%
===========================================
Files 175 175
Lines 52371 52371
===========================================
- Hits 48184 21340 -26844
- Misses 4187 31031 +26844
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26159 +/- ##
==========================================
- Coverage 91.98% 91.98% -0.01%
==========================================
Files 175 175
Lines 52372 52372
==========================================
- Hits 48176 48173 -3
- Misses 4196 4199 +3
Continue to review full report at Codecov.
|
this has some failures (ignore the 3.7 numpy_dev ones for now), but the others are legit |
can you merge master |
8fb34f7
to
642dfbe
Compare
return "%s(%s)" % (self.__class__.__name__, | ||
str(self)) | ||
return "{class_name}({list!s})".format( | ||
class_name=self.__class__.__name__, list=self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use a kwarg other than list
here to avoid overlap with builtin name
closing as stale; ping if you want to continue |
progress towards #16130
git diff upstream/master -u -- "*.py" | flake8 --diff