-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
GH26139, DOC: Explicit statement of default complevel for HDFStore #26158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26158 +/- ##
==========================================
- Coverage 92% 91.99% -0.01%
==========================================
Files 175 175
Lines 52371 52371
==========================================
- Hits 48184 48180 -4
- Misses 4187 4191 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26158 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.01%
==========================================
Files 175 175
Lines 52377 52377
==========================================
- Hits 48180 48176 -4
- Misses 4197 4201 +4
Continue to review full report at Codecov.
|
@swyoon : This is looking good! Can you merge / rebase onto |
@gfyoung All checks are green. |
Thanks @swyoon ! As a follow-up, if you would like to change the default from |
@gfyoung My pleasure! So 1) change defaults to 0, and 2) raise deprecation warning when None value is given. |
@swyoon : Given that |
@gfyoung got it. |
nothing needs changing here |
State what
None
complevel inHDFStore
means explicitly.