Skip to content

Fix Type Annotation in pandas.core.accessor #26147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vaibhavhrt
Copy link
Contributor

@vaibhavhrt vaibhavhrt commented Apr 19, 2019

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #26147 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26147      +/-   ##
==========================================
- Coverage   91.99%   91.97%   -0.02%     
==========================================
  Files         175      175              
  Lines       52383    52378       -5     
==========================================
- Hits        48188    48177      -11     
- Misses       4195     4201       +6
Flag Coverage Δ
#multiple 90.53% <100%> (-0.01%) ⬇️
#single 40.71% <100%> (-0.17%) ⬇️
Impacted Files Coverage Δ
pandas/core/accessor.py 98.8% <100%> (+0.01%) ⬆️
pandas/util/_doctools.py 0% <0%> (-12%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-8.56%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/core/arrays/interval.py 93.06% <0%> (-0.06%) ⬇️
pandas/core/indexes/interval.py 95.22% <0%> (-0.03%) ⬇️
pandas/core/arrays/sparse.py 92.3% <0%> (ø) ⬆️
pandas/core/arrays/integer.py 96.34% <0%> (+0.01%) ⬆️
pandas/core/dtypes/dtypes.py 96.42% <0%> (+0.08%) ⬆️
pandas/core/groupby/ops.py 95.97% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53bb06...dbadecb. Read the comment docs.

@vaibhavhrt vaibhavhrt changed the title remove the module from mypy.ini and add type annotation Fix Type Annotation in pandas.core.accessor Apr 19, 2019
@WillAyd
Copy link
Member

WillAyd commented Apr 19, 2019

Can you double check remaining modules while at it to make sure this is current?

@vaibhavhrt
Copy link
Contributor Author

vaibhavhrt commented Apr 19, 2019

Ok, I will check all the modules in mypy.ini, but that will take some time. I will remove all unnecessary modules from mypy.ini by tomorrow, or add a comment here if there are none.

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Apr 19, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 20, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on annotation

@vaibhavhrt
Copy link
Contributor Author

Comment on annotation

@WillAyd Comment what on what. Sorry I didn't get what you actually mean.

Can you double check remaining modules while at it to make sure this is current?

I am still checking the modules in mypy.ini for any unnecessary modules. I will be done tomorrow.

@vaibhavhrt
Copy link
Contributor Author

@WillAyd I found few more unnecessary modules in mypy.ini. I have commented them out so that you can take a look and also to make sure tests pass. I will remove them after tests pass.

@WillAyd
Copy link
Member

WillAyd commented Apr 21, 2019

@vaibhavhrt feel free to remove and fix up lint issue

@vaibhavhrt
Copy link
Contributor Author

@WillAyd all done. @jreback you can go ahead and merge this PR of everything looks ok to you.

@jreback jreback merged commit 55abdc5 into pandas-dev:master Apr 21, 2019
@jreback
Copy link
Contributor

jreback commented Apr 21, 2019

thanks @vaibhavhrt

@vaibhavhrt vaibhavhrt deleted the type-annotation-pandas/core/accessor.py branch April 21, 2019 16:56
ryanreh99 pushed a commit to ryanreh99/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Type Annotation in pandas/core/accessor.py
3 participants