-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix Type Annotation in pandas.core.accessor #26147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Type Annotation in pandas.core.accessor #26147
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26147 +/- ##
==========================================
- Coverage 91.99% 91.97% -0.02%
==========================================
Files 175 175
Lines 52383 52378 -5
==========================================
- Hits 48188 48177 -11
- Misses 4195 4201 +6
Continue to review full report at Codecov.
|
Can you double check remaining modules while at it to make sure this is current? |
Ok, I will check all the modules in mypy.ini, but that will take some time. I will remove all unnecessary modules from mypy.ini by tomorrow, or add a comment here if there are none. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on annotation
@WillAyd Comment what on what. Sorry I didn't get what you actually mean.
I am still checking the modules in |
@WillAyd I found few more unnecessary modules in |
@vaibhavhrt feel free to remove and fix up lint issue |
thanks @vaibhavhrt |
git diff upstream/master -u -- "*.py" | flake8 --diff