Skip to content

Cython Unicode Method Cleanups #26138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2019

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Apr 18, 2019

Removal of some items that should no longer be required after Py2 drop

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #26138 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26138      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52387    52385       -2     
==========================================
- Hits        48191    48186       -5     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.54% <ø> (ø) ⬆️
#single 40.74% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/dtypes/cast.py 91.5% <ø> (+0.13%) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd9c585...0960a36. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #26138 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26138      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52387    52385       -2     
==========================================
- Hits        48191    48186       -5     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.54% <ø> (ø) ⬆️
#single 40.74% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/dtypes/cast.py 91.5% <ø> (+0.13%) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd9c585...0960a36. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Apr 18, 2019
@jreback jreback merged commit 1c0f8cf into pandas-dev:master Apr 18, 2019
@jreback
Copy link
Contributor

jreback commented Apr 18, 2019

thanks @WillAyd

@WillAyd WillAyd deleted the cython-unicode-meth-cleanup branch April 18, 2019 20:02
yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants