-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Updated PeriodIndex docstrings #10094 #26115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wasn't sure what to add in the whatsnew entry. Some guidance would be appreciated. |
Codecov Report
@@ Coverage Diff @@
## master #26115 +/- ##
===========================================
- Coverage 91.99% 40.74% -51.26%
===========================================
Files 175 175
Lines 52384 52384
===========================================
- Hits 48189 21342 -26847
- Misses 4195 31042 +26847
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26115 +/- ##
==========================================
- Coverage 91.99% 91.98% -0.01%
==========================================
Files 175 175
Lines 52384 52384
==========================================
- Hits 48189 48184 -5
- Misses 4195 4200 +5
Continue to review full report at Codecov.
|
Also unsure as to why code coverage issues are so significant. |
These updates look good. No whatsnew is required for docstring updates. Does this fully close the issue referenced? @jorisvandenbossche |
Thanks @ExSidius |
No problem. |
From a quick search it seems it does. Thanks @ExSidius |
Cheers. Happy to help. |
git diff upstream/master -u -- "*.py" | flake8 --diff