Skip to content

Updated PeriodIndex docstrings #10094 #26115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Updated PeriodIndex docstrings #10094 #26115

merged 3 commits into from
Apr 17, 2019

Conversation

ExSidius
Copy link
Contributor

@ExSidius ExSidius commented Apr 17, 2019

@pep8speaks
Copy link

pep8speaks commented Apr 17, 2019

Hello @ExSidius! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-17 00:52:02 UTC

@ExSidius
Copy link
Contributor Author

I wasn't sure what to add in the whatsnew entry. Some guidance would be appreciated.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #26115 into master will decrease coverage by 51.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26115       +/-   ##
===========================================
- Coverage   91.99%   40.74%   -51.26%     
===========================================
  Files         175      175               
  Lines       52384    52384               
===========================================
- Hits        48189    21342    -26847     
- Misses       4195    31042    +26847
Flag Coverage Δ
#multiple ?
#single 40.74% <ø> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 43.65% <ø> (-54.88%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68b1da7...f562dcd. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #26115 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26115      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52384    52384              
==========================================
- Hits        48189    48184       -5     
- Misses       4195     4200       +5
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.74% <ø> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.53% <ø> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.61% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68b1da7...f562dcd. Read the comment docs.

@ExSidius
Copy link
Contributor Author

Also unsure as to why code coverage issues are so significant.

@WillAyd WillAyd added the Docs label Apr 17, 2019
@WillAyd
Copy link
Member

WillAyd commented Apr 17, 2019

These updates look good. No whatsnew is required for docstring updates.

Does this fully close the issue referenced? @jorisvandenbossche

@WillAyd WillAyd added this to the 0.25.0 milestone Apr 17, 2019
@WillAyd WillAyd merged commit b2ef74d into pandas-dev:master Apr 17, 2019
@WillAyd
Copy link
Member

WillAyd commented Apr 17, 2019

Thanks @ExSidius

@ExSidius
Copy link
Contributor Author

No problem.

@jorisvandenbossche
Copy link
Member

Does this fully close the issue referenced? @jorisvandenbossche

From a quick search it seems it does. Thanks @ExSidius

@ExSidius
Copy link
Contributor Author

Cheers. Happy to help.

yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: update docstrings with new Index repr
4 participants