Improve documentation for assert_frame|series_equal #26101 #26106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26106 +/- ##
==========================================
+ Coverage 91.96% 91.97% +0.01%
==========================================
Files 175 175
Lines 52405 52377 -28
==========================================
- Hits 48192 48176 -16
+ Misses 4213 4201 -12
Continue to review full report at Codecov.
|
WillAyd
requested changes
Apr 17, 2019
pandas/util/testing.py
Outdated
| @@ -1001,6 +1001,12 @@ def assert_series_equal(left, right, check_dtype=True, | |||
| obj : str, default 'Series' | |||
| Specify object name being compared, internally used to show appropriate | |||
| assertion message. | |||
|
|
|||
| When comparing two numbers, if the first number has magnitude less | |||
There was a problem hiding this comment.
These belong as part of the description of check_less_precise
|
lgtm. @WillAyd |
WillAyd
approved these changes
Apr 22, 2019
|
Thanks @sandepp123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff