ERR: better error message on too large excel sheet #26080

anordin95 · 2019-04-14T04:21:39Z

closes to_excel cannot handle large sheet #26051
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff

pep8speaks · 2019-04-14T04:21:44Z

Hello @anordin95! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-01 12:43:43 UTC

codecov · 2019-04-14T04:37:17Z

Codecov Report

❗ No coverage uploaded for pull request base (master@190a69e). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #26080   +/-   ##
=========================================
  Coverage          ?   40.75%           
=========================================
  Files             ?      175           
  Lines             ?    52449           
  Branches          ?        0           
=========================================
  Hits              ?    21373           
  Misses            ?    31076           
  Partials          ?        0

Flag	Coverage Δ
#single	`40.75% <0%> (?)`

Impacted Files	Coverage Δ
pandas/core/generic.py	`37.75% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190a69e...c5f9db9. Read the comment docs.

codecov · 2019-04-14T04:37:17Z

Codecov Report

Merging #26080 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #26080      +/-   ##
==========================================
+ Coverage   91.76%   91.83%   +0.07%     
==========================================
  Files         174      174              
  Lines       50625    50649      +24     
==========================================
+ Hits        46458    46516      +58     
+ Misses       4167     4133      -34

Flag	Coverage Δ
#multiple	`90.37% <100%> (+0.07%)`	⬆️
#single	`41.69% <40%> (-0.08%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/formats/excel.py	`97.44% <100%> (+0.04%)`	⬆️
pandas/io/gbq.py	`78.94% <0%> (-10.53%)`	⬇️
pandas/core/frame.py	`97% <0%> (-0.12%)`	⬇️
pandas/core/groupby/groupby.py	`97.17% <0%> (-0.06%)`	⬇️
pandas/core/indexes/multi.py	`95.62% <0%> (ø)`	⬆️
pandas/core/sparse/scipy_sparse.py	`100% <0%> (ø)`	⬆️
pandas/core/groupby/__init__.py	`100% <0%> (ø)`	⬆️
pandas/core/arrays/categorical.py	`95.91% <0%> (ø)`	⬆️
pandas/core/indexes/base.py	`96.71% <0%> (ø)`	⬆️
pandas/core/series.py	`93.61% <0%> (ø)`	⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f693f...66f4602. Read the comment docs.

pandas/core/generic.py

pandas/tests/generic/test_generic.py

pandas/core/generic.py

… deprecation error.

pandas/io/formats/excel.py

WillAyd

Looks like CI is just failing with lint errors so be sure to give them a look.

As far as my environment is concerned I'm just using the environment.yaml file that comes with this repo; if you are having a lot of trouble maybe try deleting what you have and rebuild from that

pandas/core/generic.py

pandas/tests/io/test_excel.py

jreback · 2019-05-12T21:12:14Z

pls merge master and update to comments

anordin95 · 2019-05-13T19:17:58Z

any suggestions on how to deal with the memoryerror?

TomAugspurger · 2019-05-13T19:27:34Z

Perhaps mock / monkeypatch setting the maximum rows & columns to a smaller size just for that test?

…

On Mon, May 13, 2019 at 2:18 PM Alexander Nordin ***@***.***> wrote: any suggestions on how to deal with the memoryerror? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#26080?email_source=notifications&email_token=AAKAOIW5VPSC5RTROY7ERGTPVG5G3A5CNFSM4HFZU4MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVJJHPA#issuecomment-491951036>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIUOB37KYDECVJP77JTPVG5G3ANCNFSM4HFZU4MA> .

pandas/tests/io/test_excel.py

WillAyd

Great - I think last commit looks very nice. Can you add a whatsnew note for v0.25?

jreback

minor comments, needs a whatsnew as @WillAyd mentioned; ping on green.

pandas/tests/io/test_excel.py

anordin95 · 2019-05-19T03:17:30Z

how do i go about adding a whatsnew note?

WillAyd · 2019-05-19T03:27:55Z

@anordin95 look in doc/source/whatsnew/v0.25.0.rst

jreback · 2019-05-19T18:12:58Z

you have a lint error as well

./pandas/tests/io/test_excel.py(1220,9): error E265: block comment should start with '# '
Bash exited with code '1'.

WillAyd

Can you fix up merge conflict and address suggestion on wording?

doc/source/whatsnew/v0.25.0.rst

anordin95 · 2019-05-24T21:19:24Z

I pulled master, then rebased onto my branch and have just pushed that, however the rebase had no errors. What's the suggested method to resolve conflicts?

jreback · 2019-05-26T15:59:26Z

looks good, can you merge master as there is a conflict; ping on green.

anordin95 · 2019-05-27T21:36:51Z

Thank you for all your help :)

doc/source/whatsnew/v0.25.0.rst

simonjayhawkins · 2019-05-27T22:52:15Z

not sure about the test failure, it looks unrelated to your changes.

simonjayhawkins · 2019-05-28T22:14:22Z

@anordin95 : the CI failures are fixed. can you merge master.

jreback

small doc comment, if you'd merge master and ping on green.

doc/source/whatsnew/v0.25.0.rst

anordin95 · 2019-06-01T12:54:09Z

I've addressed the requested changes. Could someone provide guidance on how to merge? It appears, I don't have the privilege.

WillAyd · 2019-06-01T12:57:36Z

One of the maintainers can merge when the CI finishes. Ping when all green

jreback · 2019-06-01T14:04:21Z

thanks @anordin95

BUG resolving issue 26051 and adding a unit test.

05503fa

CLN. Cleaning up PEP-8 errors.

c5f9db9

anordin95 closed this Apr 14, 2019

anordin95 reopened this Apr 14, 2019

gfyoung reviewed Apr 14, 2019

View reviewed changes

pandas/core/generic.py Outdated Show resolved Hide resolved

gfyoung reviewed Apr 14, 2019

View reviewed changes

pandas/tests/generic/test_generic.py Outdated Show resolved Hide resolved

gfyoung added Error Reporting Incorrect or improved errors from pandas IO Excel read_excel, to_excel labels Apr 14, 2019

jreback requested changes Apr 15, 2019

View reviewed changes

pandas/core/generic.py Outdated Show resolved Hide resolved

Stylistic changes.

f6abceb

jreback requested changes Apr 26, 2019

View reviewed changes

pandas/core/generic.py Outdated Show resolved Hide resolved

Remove f strings due to python3.5 incompatibility.

65fe420

jreback requested changes Apr 28, 2019

View reviewed changes

pandas/core/generic.py Outdated Show resolved Hide resolved

jreback changed the title ~~BUG resolving issue 26051 and adding a unit test.~~ ERR: better error message on too large excel sheet Apr 28, 2019

Moved code to excel.py and test_excel.py. Pytests failing due to xlrd…

e0a9b7e

… deprecation error.

WillAyd requested changes May 2, 2019

View reviewed changes

pandas/io/formats/excel.py Outdated Show resolved Hide resolved

df -> self.df. new error: Pending Deprecation Warning

10ca447

WillAyd requested changes May 2, 2019

View reviewed changes

Addressed comments + ensured lint success.

ed5d3b3

WillAyd requested changes May 13, 2019

View reviewed changes

pandas/tests/io/test_excel.py Outdated Show resolved Hide resolved

re-structure test to decrease memory useage.

dedf5db

WillAyd requested changes May 14, 2019

View reviewed changes

Alex Nordin and others added 2 commits May 14, 2019 15:06

fix misnaming

fde1703

stylistic fixes

e035a2d

jreback requested changes May 16, 2019

View reviewed changes

pandas/tests/io/test_excel.py Show resolved Hide resolved

pandas/tests/io/test_excel.py Outdated Show resolved Hide resolved

Formatting updates to pass lint tests

66dbb51

Fix lint error and update whatsnew.

f152e2e

WillAyd requested changes May 24, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

Rephrase whatsnew

4910e80

jreback added this to the 0.25.0 milestone May 26, 2019

Merge branch 'master' into to_excel_large_sheet_handling

f07c0da

simonjayhawkins reviewed May 27, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

Alex Nordin added 2 commits May 27, 2019 20:06

Formatting fix

eff1618

fix formatting changes

447b000

jreback requested changes May 30, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

whatsnew update

66f4602

WillAyd approved these changes Jun 1, 2019

View reviewed changes

jreback approved these changes Jun 1, 2019

View reviewed changes

jreback merged commit 7f3423c into pandas-dev:master Jun 1, 2019

vaibhavhrt pushed a commit to vaibhavhrt/pandas that referenced this pull request Jun 6, 2019

ERR: better error message on too large excel sheet (pandas-dev#26080)

c591569

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ERR: better error message on too large excel sheet #26080

ERR: better error message on too large excel sheet #26080

anordin95 commented Apr 14, 2019

pep8speaks commented Apr 14, 2019 •

edited

Loading

codecov bot commented Apr 14, 2019

codecov bot commented Apr 14, 2019 •

edited

Loading

WillAyd left a comment

jreback commented May 12, 2019

anordin95 commented May 13, 2019

TomAugspurger commented May 13, 2019 via email

WillAyd left a comment

jreback left a comment

anordin95 commented May 19, 2019

WillAyd commented May 19, 2019

jreback commented May 19, 2019

WillAyd left a comment

anordin95 commented May 24, 2019

jreback commented May 26, 2019

anordin95 commented May 27, 2019

simonjayhawkins commented May 27, 2019

simonjayhawkins commented May 28, 2019

jreback left a comment

anordin95 commented Jun 1, 2019

WillAyd commented Jun 1, 2019

jreback commented Jun 1, 2019

ERR: better error message on too large excel sheet #26080

ERR: better error message on too large excel sheet #26080

Conversation

anordin95 commented Apr 14, 2019

pep8speaks commented Apr 14, 2019 • edited Loading

Comment last updated at 2019-06-01 12:43:43 UTC

codecov bot commented Apr 14, 2019

Codecov Report

codecov bot commented Apr 14, 2019 • edited Loading

Codecov Report

WillAyd left a comment

Choose a reason for hiding this comment

jreback commented May 12, 2019

anordin95 commented May 13, 2019

TomAugspurger commented May 13, 2019 via email

WillAyd left a comment

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

anordin95 commented May 19, 2019

WillAyd commented May 19, 2019

jreback commented May 19, 2019

WillAyd left a comment

Choose a reason for hiding this comment

anordin95 commented May 24, 2019

jreback commented May 26, 2019

anordin95 commented May 27, 2019

simonjayhawkins commented May 27, 2019

simonjayhawkins commented May 28, 2019

jreback left a comment

Choose a reason for hiding this comment

anordin95 commented Jun 1, 2019

WillAyd commented Jun 1, 2019

jreback commented Jun 1, 2019

pep8speaks commented Apr 14, 2019 •

edited

Loading

codecov bot commented Apr 14, 2019 •

edited

Loading