Skip to content

DOC: fix errors/warnings in running code blocks #26076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2019

Conversation

jorisvandenbossche
Copy link
Member

Cleaning up errors / warnings in the doc build, related to the ipython code blocks:

  • put a section about hdf5 and Panel in verbatim code blocks + added some :okwarning: for Panel (will need to be properly cleaned up when Panel is removed)
  • fixed cases that raised deprecation warning for TimedeltaIndex.fillna() with integers
  • reworded case that raised deprecation warning about passing integers + timezone to DatetimeIndex
  • pd.core.config doesn't exist anymore -> removed that call + made the actual example verbatim

@jorisvandenbossche jorisvandenbossche added this to the 0.25.0 milestone Apr 13, 2019
@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #26076 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26076      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files         175      175              
  Lines       52509    52509              
==========================================
- Hits        48255    48251       -4     
- Misses       4254     4258       +4
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 40.74% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a15069...fbba132. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #26076 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26076      +/-   ##
==========================================
+ Coverage   91.89%   91.94%   +0.04%     
==========================================
  Files         175      175              
  Lines       52509    52427      -82     
==========================================
- Hits        48255    48204      -51     
+ Misses       4254     4223      -31
Flag Coverage Δ
#multiple 90.5% <ø> (+0.05%) ⬆️
#single 40.73% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/util/_doctools.py 12% <0%> (-0.88%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.13%) ⬇️
pandas/core/computation/ops.py 95.62% <0%> (-0.04%) ⬇️
pandas/core/computation/align.py 97.8% <0%> (-0.03%) ⬇️
pandas/core/reshape/melt.py 97.47% <0%> (-0.03%) ⬇️
pandas/plotting/_core.py 83.76% <0%> (-0.02%) ⬇️
pandas/util/testing.py 90.61% <0%> (-0.01%) ⬇️
pandas/core/sparse/frame.py 95.49% <0%> (-0.01%) ⬇️
pandas/core/sorting.py 98.29% <0%> (-0.01%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a15069...ec8396d. Read the comment docs.

@@ -161,6 +161,7 @@ Other enhancements:
- ``Panel`` now supports the ``all`` and ``any`` aggregation functions. (:issue:`8302`):

.. ipython:: python
:okwarning:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob should change this to a code-block (good for followup though)

@@ -702,6 +702,7 @@ Other notable API changes:
This can also be seen in multi-axis indexing with a ``Panel``.

.. ipython:: python
:okwarning:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@jreback
Copy link
Contributor

jreback commented Apr 15, 2019

small comment. add Panel to code-blocks in 2 places or followup is ok.

@jorisvandenbossche
Copy link
Member Author

small comment. add Panel to code-blocks in 2 places or followup is ok.

Yeah, we indeed need to convert those to actual code-blocks at some point. But there are still some other occurrences as well, so will leave that for a separate PR.

@jorisvandenbossche jorisvandenbossche merged commit aad7739 into pandas-dev:master Apr 16, 2019
@jorisvandenbossche jorisvandenbossche deleted the doc-fixes branch April 16, 2019 07:26
yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants