-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: prevent overflowing diffs raising error in cut (#26045) #26063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26063 +/- ##
===========================================
- Coverage 91.89% 40.73% -51.16%
===========================================
Files 175 175
Lines 52493 52493
===========================================
- Hits 48239 21384 -26855
- Misses 4254 31109 +26855
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26063 +/- ##
==========================================
- Coverage 91.99% 91.98% -0.01%
==========================================
Files 175 175
Lines 52384 52384
==========================================
- Hits 48189 48185 -4
- Misses 4195 4199 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple small comments.
@jreback are we good on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny comments, ping on green.
@jreback All good, I also merged upstream. Thanks for your time & patience ! |
thanks @Batalex nice patch & responsiveness. keep em coming! |
git diff upstream/master -u -- "*.py" | flake8 --diff
I added a relevant test with the example reported in the issue in
\tests\reshape\test_cut.py
.I also tested with
grep -rn pandas -e 'np.diff(bins'
if we could have a similar situation elsewhere but it does not seem so.I will merge upstream & add changelog entry.Edit: whatsnew entry added & no need to merge master