-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: rolling.count with axis=1 #26055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
da47224
Added axis to constructor call in count
yhaque1213 c64c76a
TST: GH26055 added test_count_axis to TestRolling
yhaque1213 90c6915
TST: fixed asserts and pep8 for test_count_axis()
yhaque1213 4906502
TST: GH26055 rebasing with master
yhaque1213 c6e1232
TST: GH26055 added whatsnew entry and renamed result and expected var…
yhaque1213 41ae7fe
TST: GH26055 corrected doc errors and test pep8 errors
yhaque1213 12065b6
TST: GH26055 fixed comment typo
yhaque1213 80c8648
TST: GH26055 fixed docs description and added axis_frame to test
yhaque1213 0f94d87
Combined description in doc and modified if statement in test to corr…
yhaque1213 1c0f475
TST: GH26055 Same changes as previous commit, merge did not pass chec…
yhaque1213 b0eae9e
Merge branch 'master' into count-axis-fix
yhaque1213 0317be0
CLN: GH26055 fixed doc and undid unintentionally added commits
yhaque1213 852ed4a
DOC: GH26055 removed extra doc line
yhaque1213 0777c54
DOC: GH26055 removed extra doc lines
yhaque1213 6c99ab3
DOC: GH26055 readded accidentally removed doc lines
yhaque1213 5b87937
DOC: GH26055 removed extra space
yhaque1213 25d6cb2
DOC: GH26055 merged doc conflicts
yhaque1213 73208dc
Added axis to constructor call in count
yhaque1213 308077f
TST: GH26055 merging test conflicts
yhaque1213 1265757
BUG: GH26055 removed extra assignment in constructor call
yhaque1213 a23c176
DOC: GH26055 removed rebase message
yhaque1213 42c10af
DOC: GH26055 merging doc conflicts
yhaque1213 fff256d
DOC: GH26055 updated docs to reserve merge conflict
yhaque1213 3ba5d35
DOC: GH26055 removed typo from doc
yhaque1213 9b2b960
Added axis to constructor call in count
yhaque1213 b8a6cae
DOC: GH26055 removed extra doc lines
yhaque1213 34e3018
DOC: GH26055 readded accidentally removed doc lines
yhaque1213 36d1c4e
DOC: GH26055 removed extra space
yhaque1213 499d910
BUG: GH26055 removed extra assignment in constructor call
yhaque1213 2786a8c
DOC: GH26055 removed rebase message
yhaque1213 d040376
DOC: GH26055 removed typo
yhaque1213 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this to test_rolling_axis_count, rename the test right above to test_rolling_axis_sum