Skip to content

CLN: Remove PY2/PY3 flags from pandas.compat #26047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2019
Merged

CLN: Remove PY2/PY3 flags from pandas.compat #26047

merged 3 commits into from
Apr 13, 2019

Conversation

jschendel
Copy link
Member

@jschendel jschendel commented Apr 11, 2019 •
edited
Loading

@jschendel jschendel added this to the 0.25.0 milestone Apr 11, 2019
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #26047 into master will increase coverage by 0.04%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26047      +/-   ##
==========================================
+ Coverage    91.9%   91.94%   +0.04%     
==========================================
  Files         175      175              
  Lines       52485    52421      -64     
==========================================
- Hits        48235    48201      -34     
+ Misses       4250     4220      -30
Flag Coverage Δ
#multiple 90.5% <97.14%> (+0.05%) ⬆️
#single 40.76% <62.85%> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/timedeltas.py 88.58% <ø> (+0.31%) ⬆️
pandas/core/indexes/timedeltas.py 90.73% <ø> (+0.45%) ⬆️
pandas/core/ops.py 91.82% <ø> (+0.09%) ⬆️
pandas/core/arrays/sparse.py 92.3% <ø> (+0.1%) ⬆️
pandas/core/indexes/base.py 96.99% <ø> (+0.2%) ⬆️
pandas/core/indexes/range.py 97.97% <ø> (+0.55%) ⬆️
pandas/compat/__init__.py 92.3% <100%> (+14.66%) ⬆️
pandas/core/strings.py 98.86% <100%> (+0.26%) ⬆️
pandas/core/dtypes/dtypes.py 96.32% <100%> (+0.21%) ⬆️
pandas/core/arrays/base.py 99.43% <100%> (+1.09%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02ec8f...31e4535. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 11, 2019 •
edited
Loading

Codecov Report

Merging #26047 into master will increase coverage by 0.04%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26047      +/-   ##
==========================================
+ Coverage    91.9%   91.94%   +0.04%     
==========================================
  Files         175      175              
  Lines       52485    52420      -65     
==========================================
- Hits        48235    48200      -35     
+ Misses       4250     4220      -30
Flag Coverage Δ
#multiple 90.5% <97.14%> (+0.05%) ⬆️
#single 40.76% <62.85%> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/timedeltas.py 88.58% <ø> (+0.31%) ⬆️
pandas/core/indexes/timedeltas.py 90.73% <ø> (+0.45%) ⬆️
pandas/core/ops.py 91.82% <ø> (+0.09%) ⬆️
pandas/core/arrays/sparse.py 92.3% <ø> (+0.1%) ⬆️
pandas/core/indexes/base.py 96.99% <ø> (+0.2%) ⬆️
pandas/core/indexes/range.py 97.97% <ø> (+0.55%) ⬆️
pandas/compat/__init__.py 92.3% <100%> (+14.66%) ⬆️
pandas/core/strings.py 98.86% <100%> (+0.26%) ⬆️
pandas/core/dtypes/dtypes.py 96.32% <100%> (+0.21%) ⬆️
pandas/core/arrays/base.py 99.43% <100%> (+1.09%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02ec8f...27b65c4. Read the comment docs.

@mroeschke
Copy link
Member

Does this technically close #25725? Some of the functions in compat/__init__.py could still be cleaned up, but I think there's no more PY2 compat after this PR.

@gfyoung
Copy link
Member

gfyoung commented Apr 11, 2019

@mroeschke : I think it does. 🎉 I've updated the PR description accordingly.

@jschendel : Could you update the module docstring to indicate this no longer is compat for PY2?

@jschendel
Copy link
Member Author

jschendel commented Apr 11, 2019 •
edited
Loading

Does this technically close #25725?

There are still a few small odds and ends left to address. Will detail them in the main issue later on today.

Could you update the module docstring to indicate this no longer is compat for PY2?

Sure, will get that done later today too.

@jschendel jschendel mentioned this pull request Apr 12, 2019
Closed
mroeschke
mroeschke approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jreback
jreback approved these changes Apr 13, 2019
View reviewed changes
pandas/core/dtypes/dtypes.py
@@ -122,21 +120,12 @@ def __unicode__(self):
def __str__(self):
"""
Return a string representation for a particular Object

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might not even need to define str and unicode here and in base.py (future PR)

@jreback
Copy link
Contributor

jreback commented Apr 13, 2019

merge away

@mroeschke mroeschke merged commit 190a69e into pandas-dev:master Apr 13, 2019
@mroeschke
Copy link
Member

Thanks @jschendel

topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 14, 2019
@jschendel @topper-123
CLN: Remove PY2/PY3 flags from pandas.compat (pandas-dev#26047)
1a8400e 
* CLN: Remove PY2/PY3 flags from pandas.compat

* lint

* no longer mention py2
@jschendel jschendel deleted the remove-compat-py2-py3 branch April 15, 2019 16:39
yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
@jschendel @yhaque1213
CLN: Remove PY2/PY3 flags from pandas.compat (pandas-dev#26047)
6525862 
* CLN: Remove PY2/PY3 flags from pandas.compat

* lint

* no longer mention py2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jschendel @mroeschke @gfyoung @jreback