Skip to content

BUG: Fix NaT comparisons with Timedelta (#26039) #26046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 28, 2019

Conversation

ArtificialQualia
Copy link
Contributor

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #26046 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26046      +/-   ##
==========================================
- Coverage    91.9%   91.89%   -0.01%     
==========================================
  Files         175      175              
  Lines       52485    52485              
==========================================
- Hits        48235    48231       -4     
- Misses       4250     4254       +4
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 40.77% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9b702...b3ca30c. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #26046 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26046      +/-   ##
==========================================
+ Coverage    91.9%   91.97%   +0.06%     
==========================================
  Files         175      175              
  Lines       52485    52379     -106     
==========================================
- Hits        48235    48174      -61     
+ Misses       4250     4205      -45
Flag Coverage Δ
#multiple 90.52% <ø> (+0.07%) ⬆️
#single 40.7% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/util/_doctools.py 0% <0%> (-12.88%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-8.56%) ⬇️
pandas/core/indexing.py 90.53% <0%> (-0.35%) ⬇️
pandas/core/sparse/frame.py 95.49% <0%> (-0.21%) ⬇️
pandas/core/computation/engines.py 88.33% <0%> (-0.2%) ⬇️
pandas/util/testing.py 90.61% <0%> (-0.12%) ⬇️
pandas/tseries/holiday.py 93.1% <0%> (-0.11%) ⬇️
pandas/plotting/_core.py 83.76% <0%> (-0.11%) ⬇️
pandas/core/panel.py 35.43% <0%> (-0.1%) ⬇️
pandas/core/arrays/interval.py 93.06% <0%> (-0.06%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9b702...cef2794. Read the comment docs.

@jschendel jschendel added Bug Datetime Datetime data dtype labels Apr 11, 2019
@jschendel jschendel added this to the 0.25.0 milestone Apr 11, 2019
@pep8speaks
Copy link

pep8speaks commented Apr 11, 2019

Hello @ArtificialQualia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-27 14:31:03 UTC

@jreback jreback merged commit 187630b into pandas-dev:master Apr 28, 2019
@jreback
Copy link
Contributor

jreback commented Apr 28, 2019

thanks @ArtificialQualia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparing Timedelta and NaT gives inconsistent results depending on order
5 participants