Skip to content

CLN: Remove PY35 flag from pandas.compat #26036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

jschendel
Copy link
Member

The PY35 flag is always True after dropping Python 2, as Python 3.5 is now the lowest supported version.

@jschendel jschendel added this to the 0.25.0 milestone Apr 10, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #26036 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26036      +/-   ##
==========================================
+ Coverage   91.84%   91.89%   +0.05%     
==========================================
  Files         175      175              
  Lines       52517    52478      -39     
==========================================
- Hits        48232    48224       -8     
+ Misses       4285     4254      -31
Flag Coverage Δ
#multiple 90.45% <100%> (+0.05%) ⬆️
#single 40.74% <100%> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 77.64% <ø> (-0.26%) ⬇️
pandas/core/computation/expr.py 96.7% <100%> (+8.14%) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.72% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66bdf...30619bc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #26036 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26036      +/-   ##
==========================================
+ Coverage   91.84%   91.89%   +0.05%     
==========================================
  Files         175      175              
  Lines       52517    52478      -39     
==========================================
- Hits        48232    48224       -8     
+ Misses       4285     4254      -31
Flag Coverage Δ
#multiple 90.45% <100%> (+0.05%) ⬆️
#single 40.74% <100%> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 77.64% <ø> (-0.26%) ⬇️
pandas/core/computation/expr.py 96.7% <100%> (+8.14%) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.72% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66bdf...30619bc. Read the comment docs.

@mroeschke mroeschke merged commit 2769ebf into pandas-dev:master Apr 10, 2019
@mroeschke
Copy link
Member

Thanks @jschendel

@jschendel jschendel deleted the remove-compat-py35 branch April 11, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants