Skip to content

CLN: PY3 compat signature #26016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2019
Merged

Conversation

mroeschke
Copy link
Member

Replace compat.signature for inspect.getfullargspec

@mroeschke mroeschke added this to the 0.25.0 milestone Apr 6, 2019
@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #26016 into master will decrease coverage by 51.09%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26016      +/-   ##
==========================================
- Coverage   91.82%   40.72%   -51.1%     
==========================================
  Files         175      175              
  Lines       52551    52536      -15     
==========================================
- Hits        48256    21397   -26859     
- Misses       4295    31139   +26844
Flag Coverage Δ
#multiple ?
#single 40.72% <25%> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 65.09% <ø> (-10.74%) ⬇️
pandas/util/_decorators.py 69.23% <0%> (-22.2%) ⬇️
pandas/core/apply.py 50.92% <50%> (-47.69%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fee91...60aca53. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #26016 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26016      +/-   ##
==========================================
- Coverage   91.82%   91.82%   -0.01%     
==========================================
  Files         175      175              
  Lines       52551    52536      -15     
==========================================
- Hits        48256    48239      -17     
- Misses       4295     4297       +2
Flag Coverage Δ
#multiple 90.38% <80%> (ø) ⬆️
#single 40.72% <20%> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 74.52% <ø> (-1.31%) ⬇️
pandas/core/apply.py 98.61% <100%> (ø) ⬆️
pandas/util/_decorators.py 91.34% <66.66%> (-0.09%) ⬇️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fee91...49749f8. Read the comment docs.

@jreback jreback merged commit d2f9228 into pandas-dev:master Apr 7, 2019
@jreback
Copy link
Contributor

jreback commented Apr 7, 2019

thanks @mroeschke

@mroeschke mroeschke deleted the py3_signature branch April 7, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants