-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
to_html formatter not called for float values in a mixed-type column #25983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 5 commits into
pandas-dev:master
from
simonjayhawkins:GenericArrayFormatter
Apr 5, 2019
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
71e8b31
to_html formatter not called for float values in a mixed-type column
simonjayhawkins 2a2bb57
changes to test as requested
simonjayhawkins 1e5615b
Merge remote-tracking branch 'upstream/master' into GenericArrayForma…
simonjayhawkins 4ca48a1
Merge branch 'master' into GenericArrayFormatter
simonjayhawkins 4ef3149
Merge remote-tracking branch 'upstream/master' into GenericArrayForma…
simonjayhawkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -633,3 +633,13 @@ def test_to_html_invalid_classes_type(classes): | |
|
||
with pytest.raises(TypeError, match=msg): | ||
df.to_html(classes=classes) | ||
|
||
|
||
def test_to_html_formatters_object_type(): | ||
# GH 13021 | ||
def f(x): | ||
return x if type(x) is str else '${:,.0f}'.format(x) | ||
|
||
df = pd.DataFrame([['a'], [0], [10.4], [3]], columns=['x']) | ||
result = df.to_html(formatters=dict(x=f)) | ||
assert '$10' in result | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we make a better assertion here? I understand the original issue pertained to floats only but probably doesn't hurt to make an assertion around the other values here as well |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use isinstance instead of type