Skip to content

CLN: PY2/3 builtin, httplib #25981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2019
Merged

Conversation

mroeschke
Copy link
Member

Also

  • Removed pandas.compat.itertools.product for itertools.product

@mroeschke mroeschke added this to the 0.25.0 milestone Apr 3, 2019
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #25981 into master will decrease coverage by 49.94%.
The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #25981       +/-   ##
===========================================
- Coverage   91.85%    41.9%   -49.95%     
===========================================
  Files         175      175               
  Lines       52554    52543       -11     
===========================================
- Hits        48272    22020    -26252     
- Misses       4282    30523    +26241
Flag Coverage Δ
#multiple ?
#single 41.9% <92.3%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/util.py 85% <ø> (-15%) ⬇️
pandas/core/base.py 33.92% <100%> (-63.86%) ⬇️
pandas/util/testing.py 50.79% <100%> (-39.83%) ⬇️
pandas/compat/__init__.py 60.83% <87.5%> (-13.61%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.36%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1172d61...90433fe. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #25981 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25981      +/-   ##
==========================================
+ Coverage   91.85%   91.85%   +<.01%     
==========================================
  Files         175      175              
  Lines       52554    52543      -11     
==========================================
- Hits        48272    48262      -10     
+ Misses       4282     4281       -1
Flag Coverage Δ
#multiple 90.4% <100%> (ø) ⬆️
#single 41.9% <92.3%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/util.py 100% <ø> (ø) ⬆️
pandas/compat/__init__.py 75.83% <100%> (+1.39%) ⬆️
pandas/core/base.py 97.78% <100%> (ø) ⬆️
pandas/util/testing.py 90.62% <100%> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1172d61...90433fe. Read the comment docs.

from pandas.compat.chainmap import DeepChainMap


# list-producing versions of the major Python iterating functions
def lrange(*args, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to completely remove these at some point as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Just moving for now since their PY2 versions used builtin

@jreback jreback merged commit caad3b5 into pandas-dev:master Apr 4, 2019
@jreback
Copy link
Contributor

jreback commented Apr 4, 2019

thanks

@mroeschke mroeschke deleted the py3_misc_imports branch April 4, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants