-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: PY2/3 builtin, httplib #25981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: PY2/3 builtin, httplib #25981
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25981 +/- ##
===========================================
- Coverage 91.85% 41.9% -49.95%
===========================================
Files 175 175
Lines 52554 52543 -11
===========================================
- Hits 48272 22020 -26252
- Misses 4282 30523 +26241
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25981 +/- ##
==========================================
+ Coverage 91.85% 91.85% +<.01%
==========================================
Files 175 175
Lines 52554 52543 -11
==========================================
- Hits 48272 48262 -10
+ Misses 4282 4281 -1
Continue to review full report at Codecov.
|
from pandas.compat.chainmap import DeepChainMap | ||
|
||
|
||
# list-producing versions of the major Python iterating functions | ||
def lrange(*args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to completely remove these at some point as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Just moving for now since their PY2 versions used builtin
thanks |
git diff upstream/master -u -- "*.py" | flake8 --diff
Also
pandas.compat.itertools.product
foritertools.product