add typing_extensions to dependencies #25975

vaibhavhrt · 2019-04-03T13:22:47Z

closes Add dependency typing_extensions for type hints #25974
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

vaibhavhrt · 2019-04-03T13:25:40Z

@WillAyd I have added typing_extensions(without freezing the version) to both environment.yml and requirements-dev.txt manually because I am not using anaconda(not a big fan of anaconda). Take a look if everything looks alright.

codecov · 2019-04-03T13:58:23Z

Codecov Report

Merging #25975 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25975      +/-   ##
==========================================
- Coverage   91.84%   91.84%   -0.01%     
==========================================
  Files         175      175              
  Lines       52550    52550              
==========================================
- Hits        48266    48262       -4     
- Misses       4284     4288       +4

Flag	Coverage Δ
#multiple	`90.39% <ø> (ø)`	⬆️
#single	`41.89% <ø> (-0.08%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	`75% <0%> (-12.5%)`	⬇️
pandas/core/frame.py	`96.79% <0%> (-0.12%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4814a28...1807a23. Read the comment docs.

codecov · 2019-04-03T13:58:34Z

Codecov Report

Merging #25975 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #25975      +/-   ##
==========================================
- Coverage   91.96%   91.95%   -0.01%     
==========================================
  Files         175      175              
  Lines       52405    52408       +3     
==========================================
- Hits        48193    48191       -2     
- Misses       4212     4217       +5

Flag	Coverage Δ
#multiple	`90.51% <100%> (ø)`	⬆️
#single	`40.73% <100%> (-0.13%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/dtypes/base.py	`100% <100%> (ø)`	⬆️
pandas/core/arrays/datetimelike.py	`97.69% <100%> (ø)`	⬆️
pandas/core/groupby/groupby.py	`97.23% <100%> (ø)`	⬆️
pandas/io/gbq.py	`75% <0%> (-12.5%)`	⬇️
pandas/core/frame.py	`96.9% <0%> (-0.12%)`	⬇️
pandas/util/testing.py	`90.61% <0%> (-0.11%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86553b...4abfc68. Read the comment docs.

WillAyd · 2019-04-03T14:10:42Z

Can you check master in a 3.5.1 environment? Might need to import Type from this library as part of this

…

Sent from my iPhone

On Apr 3, 2019, at 6:58 AM, codecov[bot] ***@***.***> wrote: Codecov Report Merging #25975 into master will decrease coverage by <.01%. The diff coverage is n/a. @@ Coverage Diff @@ ## master #25975 +/- ## ========================================== - Coverage 91.84% 91.84% -0.01% ========================================== Files 175 175 Lines 52550 52550 ========================================== - Hits 48266 48262 -4 - Misses 4284 4288 +4 Flag Coverage Δ #multiple 90.39% <ø> (ø) ⬆️ #single 41.89% <ø> (-0.08%) ⬇️ Impacted Files Coverage Δ pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️ pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️ Continue to review full report at Codecov. Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4814a28...1807a23. Read the comment docs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

vaibhavhrt · 2019-04-03T14:21:39Z

@WillAyd I am not sure what you mean.
Should I import Type from typing_extensions and then run tests in python 3.5.1 locally?

WillAyd · 2019-04-03T15:04:51Z

Can you check if current master runs on 3.5.1 first? If not then yes might need to import from type_extensions to resolve

…

Sent from my iPhone

On Apr 3, 2019, at 7:21 AM, Vaibhav Vishal ***@***.***> wrote: @WillAyd I am not sure what you mean. Should I import Type from typing_extensions and then run tests in python 3.5.1 locally? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jreback · 2019-04-03T15:35:33Z

we should pin one of the builds to 3.5.1

separately not averse to bumping to 3.5.3 (or whatever we need)

environment.yml

WillAyd · 2019-04-03T16:08:54Z

Makes sense. I think we could pin 3.5.1 as part of this PR and tackle maybe bumping to 3.5.3 separately if we wanted to

jreback

you need to add this to all of the ci builds in the pandas/ci/deps dir

jreback

need to update setup.py & the install docs as well.

WillAyd · 2019-04-03T21:19:56Z

We provide instructions for conda but you could get to the same place using pip or pipenv for sure

…

Sent from my iPhone

On Apr 3, 2019, at 1:59 PM, Vaibhav Vishal ***@***.***> wrote: @vaibhavhrt commented on this pull request. In environment.yml: > @@ -25,6 +25,7 @@ dependencies: - pytest-mock - sphinx - numpydoc + - typing_extensions @WillAyd does it matter how I create virtualenv(anaconda, pipenv) when running tests locally. My system is low on space and anaconda takes up a lot of space. So is it ok if I use pipenv to create env and then run pytest pandas or will that make any difference. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

vaibhavhrt · 2019-04-04T09:08:15Z

@WillAyd I finally managed to get MS Build Tools 14 working and build pandas. I should be able to run tests locally now. But I am too busy at work today. Tomorrow I will run tests on python 3.5.1 and let you know the results. I will take care of changes requested by @jreback too tomorrow.

TomAugspurger · 2019-04-04T11:58:57Z

What exactly are we using from this? If we’re only using one or two definitions, I’d rather just include those in our typing compat module. Adding a new dependency shouldn’t be done lightly.

WillAyd · 2019-04-04T17:55:15Z

@TomAugspurger what's the concern with third party library? There's a lot of active development with types so I think it would be more work to vendor pieces of it and keep in sync rather than to include as dependency

vaibhavhrt · 2019-04-05T07:25:35Z

@WillAyd on python 3.5.1 even master will fail. I can't even import pandas from local build. Here is relevant part of traceback:

...
  File "C:\Users\Harish\Documents\GitHub\pandas\pandas\core\dtypes\base.py", line 2, in <module>
  from typing import List, Optional, Type
ImportError: cannot import name 'Type'

typing.Type was added in 3.5.2

I will fix this.

vaibhavhrt · 2019-04-05T11:12:09Z

@WillAyd After adding typing_extensions to dependency and importing Type from typing_extensions
I got the following test results:

 22 failed, 47816 passed, 1368 skipped, 1028 xfailed, 15 xpassed, 3469 warnings in 4985.95 seconds

I can't see how any of the changes I made can make tests fail. I have pushed the changes, you can see tests results on travis and let me know how to fix it.

vaibhavhrt · 2019-04-05T11:59:11Z

@WillAyd tests are passing on travis but not locally, don't know why. Also some azure tests for mac and linux are failing. Do I remove typing-extensions from yml of those tests or should I install them from pip instead of conda?

WillAyd · 2019-04-05T15:00:09Z

You’d need to be explicit about which failures you are getting locally

…

Sent from my iPhone

On Apr 5, 2019, at 4:59 AM, Vaibhav Vishal ***@***.***> wrote: @WillAyd tests are passing on travis but not locally, don't know why. Also some azure tests for mac and linux are failing. Do I remove typing-extensions from yml of those tests or should I install them from pip instead of conda? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

vaibhavhrt · 2019-04-05T15:11:17Z

@WillAyd running tests locally takes a long time. I will worry about that some other time. Travis tests(for my fork too) is passing, so there is something wrong with my system. For now please let me know to fix the Azure tests(some of them are failing). They all have similar issue:

conda env create -q --file=ci/deps/azure-macos-35.yaml
Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies.  Conda may not use the correct pip to install your packages, and they may end up in the wrong place.  Please add an explicit pip dependency.  I'm adding one for you, but still nagging you.
Collecting package metadata: ...working... done
Solving environment: ...working... failed
WARNING: The conda.compat module is deprecated and will be removed in a future release.

ResolvePackageNotFound: 
  - typing-extensions

##[error]Bash exited with code '1'.

I think I need to change to something in the the yaml files of these tests but not sure what.

TomAugspurger · 2019-04-05T15:17:44Z

conda-forge doesn't build packages for 3.5 (which demonstrates one issue with taking on dependencies @WillAyd).

…

On Fri, Apr 5, 2019 at 10:11 AM Vaibhav Vishal ***@***.***> wrote: @WillAyd <https://github.com/WillAyd> running tests locally takes a long time. I will worry about that some other time. Travis tests(for my fork too) is passing, so there is something wrong with my system. For now please let me know to fix the Azure tests(some of them are failing). They all have similar issue: conda env create -q --file=ci/deps/azure-macos-35.yaml Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies. Conda may not use the correct pip to install your packages, and they may end up in the wrong place. Please add an explicit pip dependency. I'm adding one for you, but still nagging you. Collecting package metadata: ...working... done Solving environment: ...working... failed WARNING: The conda.compat module is deprecated and will be removed in a future release. ResolvePackageNotFound: - typing-extensions ##[error]Bash exited with code '1'. I think I need to change to something in the the yaml files of these tests but not sure what. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25975 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIj1lR-8YeAAcyyrD31XCGeSvN5o9ks5vd2edgaJpZM4cagFJ> .

WillAyd · 2019-04-05T16:30:20Z

Hmm ok. So you think better to just add Type and Final to our internal typing package? Not opposed if that’s easier

…

Sent from my iPhone

On Apr 5, 2019, at 8:17 AM, Tom Augspurger ***@***.***> wrote: conda-forge doesn't build packages for 3.5 (which demonstrates one issue with taking on dependencies @WillAyd). On Fri, Apr 5, 2019 at 10:11 AM Vaibhav Vishal ***@***.***> wrote: > @WillAyd <https://github.com/WillAyd> running tests locally takes a long > time. I will worry about that some other time. Travis tests(for my fork > too) is passing, so there is something wrong with my system. For now please > let me know to fix the Azure tests(some of them are failing). They all have > similar issue: > > conda env create -q --file=ci/deps/azure-macos-35.yaml > Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies. Conda may not use the correct pip to install your packages, and they may end up in the wrong place. Please add an explicit pip dependency. I'm adding one for you, but still nagging you. > Collecting package metadata: ...working... done > Solving environment: ...working... failed > WARNING: The conda.compat module is deprecated and will be removed in a future release. > > ResolvePackageNotFound: > - typing-extensions > > ##[error]Bash exited with code '1'. > > I think I need to change to something in the the yaml files of these > tests but not sure what. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#25975 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABQHIj1lR-8YeAAcyyrD31XCGeSvN5o9ks5vd2edgaJpZM4cagFJ> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jreback · 2019-04-16T12:01:23Z

Hmm ok. So you think better to just add Type and Final to our internal typing package? Not opposed if that’s easier

yes let's just add what we need to _typing, rather that this dep.

vaibhavhrt · 2019-04-17T05:05:26Z

@jreback if no one is already working on adding Type and Final to pandas.typing I can do that. Let me know if I should open a new issue and PR for that. I am closing this PR.

add typing_extensions to enviromnent and requirements

1807a23

WillAyd reviewed Apr 3, 2019

View reviewed changes

environment.yml Outdated Show resolved Hide resolved

WillAyd added Dependencies Required and optional dependencies Typing type annotations, mypy/pyright type checking labels Apr 3, 2019

jreback requested changes Apr 3, 2019

View reviewed changes

Merge branch 'master' into typing_extensions

5bdbd54

vaibhavhrt added 2 commits April 5, 2019 14:43

fix Type import for py3.5.1

040b2ee

update CI deps to install typying_extensions

0ad54e1

vaibhavhrt changed the title ~~add typing_extensions to environment and requirements~~ add typing_extensions to dependencies Apr 5, 2019

spell typing-extensions properly

3c31c1c

vaibhavhrt mentioned this pull request Apr 9, 2019

Fix type annotation in pandas.compat.numpy.function #25961

Merged

4 tasks

vaibhavhrt added 2 commits April 16, 2019 10:52

Merge branch 'master' into typing_extensions

c320727

trying to fix ci tests

4abfc68

vaibhavhrt closed this Apr 17, 2019

vaibhavhrt deleted the typing_extensions branch April 19, 2019 07:23

vaibhavhrt mentioned this pull request Apr 21, 2019

Add Type and Final pandas._typing #26175

Closed

WillAyd mentioned this pull request Aug 5, 2019

TYPING: add some type hints to core.generic #27646

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add typing_extensions to dependencies #25975

add typing_extensions to dependencies #25975

vaibhavhrt commented Apr 3, 2019

vaibhavhrt commented Apr 3, 2019

codecov bot commented Apr 3, 2019

codecov bot commented Apr 3, 2019 •

edited

Loading

WillAyd commented Apr 3, 2019 via email

vaibhavhrt commented Apr 3, 2019

WillAyd commented Apr 3, 2019 via email

jreback commented Apr 3, 2019

WillAyd commented Apr 3, 2019

jreback left a comment

jreback left a comment

WillAyd commented Apr 3, 2019 via email

vaibhavhrt commented Apr 4, 2019

TomAugspurger commented Apr 4, 2019

WillAyd commented Apr 4, 2019

vaibhavhrt commented Apr 5, 2019 •

edited

Loading

vaibhavhrt commented Apr 5, 2019 •

edited

Loading

vaibhavhrt commented Apr 5, 2019

WillAyd commented Apr 5, 2019 via email

vaibhavhrt commented Apr 5, 2019

TomAugspurger commented Apr 5, 2019 via email

WillAyd commented Apr 5, 2019 via email

jreback commented Apr 16, 2019

vaibhavhrt commented Apr 17, 2019

add typing_extensions to dependencies #25975

add typing_extensions to dependencies #25975

Conversation

vaibhavhrt commented Apr 3, 2019

vaibhavhrt commented Apr 3, 2019

codecov bot commented Apr 3, 2019

Codecov Report

codecov bot commented Apr 3, 2019 • edited Loading

Codecov Report

WillAyd commented Apr 3, 2019 via email

vaibhavhrt commented Apr 3, 2019

WillAyd commented Apr 3, 2019 via email

jreback commented Apr 3, 2019

WillAyd commented Apr 3, 2019

jreback left a comment

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

WillAyd commented Apr 3, 2019 via email

vaibhavhrt commented Apr 4, 2019

TomAugspurger commented Apr 4, 2019

WillAyd commented Apr 4, 2019

vaibhavhrt commented Apr 5, 2019 • edited Loading

vaibhavhrt commented Apr 5, 2019 • edited Loading

vaibhavhrt commented Apr 5, 2019

WillAyd commented Apr 5, 2019 via email

vaibhavhrt commented Apr 5, 2019

TomAugspurger commented Apr 5, 2019 via email

WillAyd commented Apr 5, 2019 via email

jreback commented Apr 16, 2019

vaibhavhrt commented Apr 17, 2019

codecov bot commented Apr 3, 2019 •

edited

Loading

vaibhavhrt commented Apr 5, 2019 •

edited

Loading

vaibhavhrt commented Apr 5, 2019 •

edited

Loading