ENH: Improve explanation when erroring on dta files #25968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
force-pushed
the
improve-cat-conversion-error
branch
from
3c35496 to
1e7243f
Compare
Codecov Report
@@ Coverage Diff @@
## master #25968 +/- ##
==========================================
- Coverage 91.84% 91.83% -0.01%
==========================================
Files 175 175
Lines 52550 52550
==========================================
- Hits 48266 48261 -5
- Misses 4284 4289 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25968 +/- ##
==========================================
- Coverage 91.86% 91.85% -0.02%
==========================================
Files 175 175
Lines 52547 52543 -4
==========================================
- Hits 48271 48262 -9
- Misses 4276 4281 +5
Continue to review full report at Codecov.
|
WillAyd
requested changes
Apr 3, 2019
gfyoung
reviewed
Apr 3, 2019
bashtage
force-pushed
the
improve-cat-conversion-error
branch
from
1e7243f to
53ad235
Compare
|
lgtm. @WillAyd |
WillAyd
approved these changes
Apr 4, 2019
|
@bashtage can you fix merge conflict and ping on green? |
bashtage
force-pushed
the
improve-cat-conversion-error
branch
from
53ad235 to
1c9c196
Compare
Improve the explanation when value labels are repeated in Stata dta files. Add suggested methods to workaround the issue using the low level interface. closes pandas-dev#25772
bashtage
force-pushed
the
improve-cat-conversion-error
branch
from
1c9c196 to
479a82a
Compare
|
@WillAyd green. |
|
thanks @bashtage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the explanation when value labels are repeated in Stata dta files.
Add suggested methods to work around the issue using the low level
interface.
closes #25772
git diff upstream/master -u -- "*.py" | flake8 --diff