Skip to content

CLN: PY3 Remove cPickle #25956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2019
Merged

CLN: PY3 Remove cPickle #25956

merged 4 commits into from
Apr 2, 2019

Conversation

mroeschke
Copy link
Member

Remove cPickle. Removes some cPickle tests.

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #25956 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25956      +/-   ##
==========================================
+ Coverage   91.82%   91.82%   +<.01%     
==========================================
  Files         175      175              
  Lines       52581    52571      -10     
==========================================
- Hits        48280    48274       -6     
+ Misses       4301     4297       -4
Flag Coverage Δ
#multiple 90.38% <100%> (+0.01%) ⬆️
#single 41.9% <62.5%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 70.96% <ø> (+0.26%) ⬆️
pandas/compat/pickle_compat.py 76.38% <100%> (+7.25%) ⬆️
pandas/core/generic.py 93.54% <100%> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.63% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c119c...ba9c60d. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 2, 2019 •
edited
Loading

Codecov Report

Merging #25956 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25956      +/-   ##
==========================================
+ Coverage   91.82%   91.82%   +<.01%     
==========================================
  Files         175      175              
  Lines       52581    52571      -10     
==========================================
- Hits        48280    48274       -6     
+ Misses       4301     4297       -4
Flag Coverage Δ
#multiple 90.38% <100%> (+0.01%) ⬆️
#single 41.9% <62.5%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 70.96% <ø> (+0.26%) ⬆️
pandas/compat/pickle_compat.py 76.38% <100%> (+7.25%) ⬆️
pandas/core/generic.py 93.54% <100%> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.63% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c119c...942dcba. Read the comment docs.

@mroeschke mroeschke added this to the 0.25.0 milestone Apr 2, 2019
jschendel
jschendel reviewed Apr 2, 2019
View reviewed changes
Copy link
Member

@jschendel jschendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm aside from a couple small comments

WillAyd
WillAyd reviewed Apr 2, 2019
View reviewed changes
pandas/io/pickle.py Outdated
@@ -140,15 +142,15 @@ def read_pickle(path, compression='infer'):
path = _stringify_path(path)
f, fh = _get_handle(path, 'rb', compression=compression, is_text=False)

# 1) try with cPickle
# 1) try with Pickle
# 2) try with the compat pickle to handle subclass changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but I suppose we don't need a three step comment here anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically there's still a 3 step process, "compat pickle" in this case refers to compatibility with older versions of pandas and not PY2/3 compat.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will clarify this comment though.

@jreback
Copy link
Contributor

jreback commented Apr 2, 2019

lgtm. @mroeschke If you want to clarify the above comment, pls do so. merge on green.

@mroeschke mroeschke merged commit f90f4aa into pandas-dev:master Apr 2, 2019
@mroeschke mroeschke deleted the py3_pickle branch April 2, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

@jschendel jschendel jschendel left review comments

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @jreback @WillAyd @jschendel