Skip to content

REF: Separate timezone-conversion from tslibs.conversion #25938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 5, 2019

Conversation

jbrockmendel
Copy link
Member

Two motivations:

  1. BUG: Fix Timestamp type checks to work with subclassed datetime (#25851) #25853 re-implements some tz-conversion code in order to avoid circular imports. By separating out this tightly-scoped, low-dependency chunk of code, we can avoid both duplication and circularity.
  2. there has been scope-creep in tslibs.conversion which was originally intended for functions converting between datetime-like objects, but has picked up a bunch of timezone-conversion functions (separated by this PR) and normalization functions (not affected by this PR)

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #25938 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25938      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52580    52581       +1     
==========================================
- Hits        48278    48275       -3     
- Misses       4302     4306       +4
Flag Coverage Δ
#multiple 90.36% <100%> (ø) ⬆️
#single 41.9% <100%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/_libs/tslibs/__init__.py 100% <100%> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3a85c...ecb7342. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9fbb9e7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #25938   +/-   ##
=========================================
  Coverage          ?   91.81%           
=========================================
  Files             ?      175           
  Lines             ?    52581           
  Branches          ?        0           
=========================================
  Hits              ?    48275           
  Misses            ?     4306           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.36% <100%> (?)
#single 41.9% <100%> (?)
Impacted Files Coverage Δ
pandas/_libs/tslibs/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fbb9e7...fefcd23. Read the comment docs.

@jreback jreback added Timezones Timezone data dtype Clean labels Apr 1, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 1, 2019
@jreback
Copy link
Contributor

jreback commented Apr 1, 2019

lgtm. can you merge master. also if you can re-check the doc-strings of the modules (conversion & tzconversion) to make sure they are appropriate. ping on green.

@jreback
Copy link
Contributor

jreback commented Apr 5, 2019

can you merge master

@jreback
Copy link
Contributor

jreback commented Apr 5, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the tzconversion branch April 5, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants