-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: Separate timezone-conversion from tslibs.conversion #25938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25938 +/- ##
==========================================
- Coverage 91.81% 91.81% -0.01%
==========================================
Files 175 175
Lines 52580 52581 +1
==========================================
- Hits 48278 48275 -3
- Misses 4302 4306 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25938 +/- ##
=========================================
Coverage ? 91.81%
=========================================
Files ? 175
Lines ? 52581
Branches ? 0
=========================================
Hits ? 48275
Misses ? 4306
Partials ? 0
Continue to review full report at Codecov.
|
lgtm. can you merge master. also if you can re-check the doc-strings of the modules (conversion & tzconversion) to make sure they are appropriate. ping on green. |
can you merge master |
thanks @jbrockmendel |
Two motivations:
tslibs.conversion
which was originally intended for functions converting between datetime-like objects, but has picked up a bunch of timezone-conversion functions (separated by this PR) and normalization functions (not affected by this PR)