Skip to content

remove is_string_object #25937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2019
Merged

remove is_string_object #25937

merged 2 commits into from
Apr 1, 2019

Conversation

jbrockmendel
Copy link
Member

now that we're py3-only, is_string_object(obj) reduces to just isinstance(obj, str) which cython already optimizes.

WillAyd
WillAyd reviewed Mar 31, 2019
View reviewed changes
pandas/_libs/tslibs/util.pxd
@@ -37,7 +37,6 @@ from numpy cimport int64_t

cdef extern from "numpy/arrayobject.h":
PyTypeObject PyFloatingArrType_Type
int _import_array() except -1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just dead code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I think i introduced it a while back as part of a failed attempt to get rid of the NPY_DEPRECATED_API warnings.

@WillAyd WillAyd added Compat pandas objects compatability with Numpy or Python functions Clean labels Mar 31, 2019
WillAyd
WillAyd approved these changes Mar 31, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd
Copy link
Member

WillAyd commented Mar 31, 2019

Probably already saw but a few small typos failing CI

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #25937 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25937      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52580    52580              
==========================================
- Hits        48278    48274       -4     
- Misses       4302     4306       +4
Flag Coverage Δ
#multiple 90.36% <ø> (ø) ⬆️
#single 41.9% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3a85c...39670b6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 31, 2019 •
edited
Loading

Codecov Report

Merging #25937 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25937      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52580    52580              
==========================================
- Hits        48278    48274       -4     
- Misses       4302     4306       +4
Flag Coverage Δ
#multiple 90.36% <ø> (ø) ⬆️
#single 41.9% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3a85c...39670b6. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Apr 1, 2019
@jreback jreback merged commit 8a9b291 into pandas-dev:master Apr 1, 2019
@jreback
Copy link
Contributor

jreback commented Apr 1, 2019

thanks

@jbrockmendel jbrockmendel deleted the strobj branch April 1, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @WillAyd @jreback