-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
fix type annotation for pandas._config.config.py #25918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix type annotation for pandas._config.config.py #25918
Conversation
… module from mypy.ini
Codecov Report
@@ Coverage Diff @@
## master #25918 +/- ##
==========================================
- Coverage 91.77% 91.77% -0.01%
==========================================
Files 175 175
Lines 52606 52607 +1
==========================================
- Hits 48280 48278 -2
- Misses 4326 4329 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25918 +/- ##
==========================================
+ Coverage 91.77% 91.81% +0.03%
==========================================
Files 175 175
Lines 52606 52581 -25
==========================================
- Hits 48280 48276 -4
+ Misses 4326 4305 -21
Continue to review full report at Codecov.
|
@WillAyd I am little confused about what type to use for namedtuple in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @jreback
thanks @vaibhavhrt |
@jreback My pleasure, looking forward to contribute more. |
@vadakattu thanks! We would ideally be able to eliminate all items from being blacklisted in mypy.ini save maybe test folders for now, so if you see other modules you want to attack feel free to open an issue / PR for it |
@WillAyd looks like you mentioned someone else by mistake. But yes I would be happy to help. I think you have listed about 60+ modules in some issue. I will start working on them one by one. Is it okay if I create the issue for each one them too myself, or will you do that? |
Go ahead and create an issue when you have one in mind |
ok, I will do that. |
also remove this module from mypy.ini
git diff upstream/master -u -- "*.py" | flake8 --diff