Skip to content

fix type annotation for pandas._config.config.py #25918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2019

Conversation

vaibhavhrt
Copy link
Contributor

@vaibhavhrt vaibhavhrt commented Mar 29, 2019

also remove this module from mypy.ini

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #25918 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25918      +/-   ##
==========================================
- Coverage   91.77%   91.77%   -0.01%     
==========================================
  Files         175      175              
  Lines       52606    52607       +1     
==========================================
- Hits        48280    48278       -2     
- Misses       4326     4329       +3
Flag Coverage Δ
#multiple 90.32% <100%> (ø) ⬆️
#single 41.9% <100%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/_config/config.py 86.86% <100%> (+0.04%) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.56% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7721f70...d0a0c4c. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #25918 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25918      +/-   ##
==========================================
+ Coverage   91.77%   91.81%   +0.03%     
==========================================
  Files         175      175              
  Lines       52606    52581      -25     
==========================================
- Hits        48280    48276       -4     
+ Misses       4326     4305      -21
Flag Coverage Δ
#multiple 90.36% <100%> (+0.04%) ⬆️
#single 41.89% <100%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/_config/config.py 86.86% <100%> (+0.04%) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/config_init.py 96.96% <0%> (-2.24%) ⬇️
pandas/core/computation/common.py 89.47% <0%> (-0.53%) ⬇️
pandas/compat/pickle_compat.py 69.13% <0%> (-0.38%) ⬇️
pandas/core/groupby/grouper.py 98.16% <0%> (-0.37%) ⬇️
pandas/compat/numpy/__init__.py 92.85% <0%> (-0.25%) ⬇️
pandas/plotting/_style.py 77.17% <0%> (-0.25%) ⬇️
pandas/core/computation/engines.py 88.52% <0%> (-0.19%) ⬇️
pandas/plotting/_timeseries.py 65.28% <0%> (-0.18%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7721f70...cc72f5b. Read the comment docs.

@vaibhavhrt
Copy link
Contributor Author

vaibhavhrt commented Mar 29, 2019

@WillAyd I am little confused about what type to use for namedtuple in _deprecated_options and _registered_options, please let me know if what I have done looks right.

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Mar 29, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Mar 29, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jreback

@jreback jreback merged commit c7c4c94 into pandas-dev:master Apr 1, 2019
@jreback
Copy link
Contributor

jreback commented Apr 1, 2019

thanks @vaibhavhrt

@vaibhavhrt vaibhavhrt deleted the Type-Annotation-Config.py branch April 1, 2019 13:19
@vaibhavhrt
Copy link
Contributor Author

@jreback My pleasure, looking forward to contribute more.

@WillAyd
Copy link
Member

WillAyd commented Apr 1, 2019

@vadakattu thanks! We would ideally be able to eliminate all items from being blacklisted in mypy.ini save maybe test folders for now, so if you see other modules you want to attack feel free to open an issue / PR for it

@vaibhavhrt
Copy link
Contributor Author

vaibhavhrt commented Apr 1, 2019

@WillAyd looks like you mentioned someone else by mistake. But yes I would be happy to help. I think you have listed about 60+ modules in some issue. I will start working on them one by one. Is it okay if I create the issue for each one them too myself, or will you do that?
I am thinking if one single person can assign modules that would be good, because there can be multiple people working on 'typing' and there can be situations when two people accidentally start working on same file. You don't have to create an issue, you can just leave a comment in the master issue that which module I should work on next, I can then take care of creating an issue and PR.

@WillAyd
Copy link
Member

WillAyd commented Apr 1, 2019

Is it okay if I create the issue for each one them too myself, or will you do that?

Go ahead and create an issue when you have one in mind

@vaibhavhrt
Copy link
Contributor Author

ok, I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Type Annotations in pandas/_config/config.py
3 participants