Skip to content

Fix pandas-gbq deps #25912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fix pandas-gbq deps #25912

merged 1 commit into from
Mar 28, 2019

Conversation

h-vetinari
Copy link
Contributor

Should close #25910, see #25910 (comment). @jreback

@h-vetinari
Copy link
Contributor Author

As a side note, it seem the gbq-tests are not actually run correctly in PRs, otherwise this should have been caught in #25554.

@jreback jreback added CI Continuous Integration Dependencies Required and optional dependencies IO Google labels Mar 28, 2019
@jreback jreback added this to the 0.25.0 milestone Mar 28, 2019
@h-vetinari h-vetinari mentioned this pull request Mar 28, 2019
Closed
WillAyd
WillAyd approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I assume can remove once 0.9.1 comes out right?

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@68dd979). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #25912   +/-   ##
=========================================
  Coverage          ?   91.55%           
=========================================
  Files             ?      175           
  Lines             ?    52775           
  Branches          ?        0           
=========================================
  Hits              ?    48320           
  Misses            ?     4455           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.12% <ø> (?)
#single 41.82% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68dd979...417454f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@68dd979). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #25912   +/-   ##
=========================================
  Coverage          ?   91.55%           
=========================================
  Files             ?      175           
  Lines             ?    52775           
  Branches          ?        0           
=========================================
  Hits              ?    48320           
  Misses            ?     4455           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.12% <ø> (?)
#single 41.82% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68dd979...417454f. Read the comment docs.

@jreback jreback merged commit 31b4019 into pandas-dev:master Mar 28, 2019
@jreback
Copy link
Contributor

jreback commented Mar 28, 2019

thanks @h-vetinari

@h-vetinari
Copy link
Contributor Author

@WillAyd: Makes sense to me. I assume can remove once 0.9.1 comes out right?

It's actually been fixed by @tswast in 0.9.0 already, so, if I understand correctly, this PR could safely be reverted now.

@h-vetinari h-vetinari deleted the gbq-fix branch March 28, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

CI: build failing because of gbq testing
3 participants
@h-vetinari @jreback @WillAyd