Implement helper method to get char* buffer from Python objects #25895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze in Python3.7 case; added docstring to get_string_data func
…et_string_data docstring
4 tasks
|
Note for reviewers: errors in CI seem to be caused by #25875 |
Codecov Report
@@ Coverage Diff @@
## master #25895 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 175 175
Lines 52863 52863
=======================================
Hits 48357 48357
Misses 4506 4506
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25895 +/- ##
==========================================
+ Coverage 91.53% 91.77% +0.23%
==========================================
Files 175 175
Lines 52808 52606 -202
==========================================
- Hits 48338 48277 -61
+ Misses 4470 4329 -141
Continue to review full report at Codecov.
|
vnlitvinov
force-pushed
the
get_string_data_pr
branch
from
0b6902b to
1db613e
Compare
|
Fun fact - it speeds up iso8601 parsing noticeably:
|
|
lgtm. @jbrockmendel ? |
|
lgtm. @jbrockmendel merge when ready. |
|
Thanks @vnlitvin |
anmyachev
pushed a commit
to anmyachev/pandas
that referenced
this pull request
Apr 18, 2019
…as-dev#25895) * removed extra layer; using get_string_data now * fix problem with const char* value, that return PyUnicode_AsUTF8AndSize in Python3.7 case; added docstring to get_string_data func * fix code style * replaced get_c_string to get_string_data, added 'note' paragraph in get_string_data docstring * Re-instate raising TypeError when trying to get string data of non-string object * test case for overflow in parse_iso_8601_datetime * change get_string_data signature to more pythonic * Added test for parsing leading spaces * Rework get_string_data to cleaner get_c_string_buf_and_size * Fix Python 3.7 compilation * added comment for test; changed name variable: s -> py_string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_parsers_iso8601_leading_spacegit diff upstream/master -u -- "*.py" | flake8 --diffThis is a follow-up PR for #25754 which adds a utility method for getting internal
char *buffer fromunicodeorbytesPython object and switch at least some of usages to it.Its advantages over what is built-in in Cython is saving at least one extra memory allocation (Cython internally calls Python C API that creates a new
char *copy which is not needed for mostunicodeobjects which are internally stored inutf8encoding), and it also obtains the length in one call.cc @jbrockmendel