Skip to content

CLN: Remove miscellaneous rarely used items from pandas.compat #25873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2019

Conversation

jschendel
Copy link
Member

Gets rid of the following from pandas.compat:

  • intern
  • reduce
  • unichr
  • wraps
  • get_range_parameters
  • class_types
  • reload
    • also removed set_defaultencoding as it used reload, was never used, and is PY2 specific
  • import_lzma
    • also removed skip_if_no_lzma since lzma is in the standard library for PY3

@jschendel jschendel added this to the 0.25.0 milestone Mar 26, 2019
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #25873 into master will decrease coverage by 49.64%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #25873       +/-   ##
===========================================
- Coverage   91.48%   41.83%   -49.65%     
===========================================
  Files         175      175               
  Lines       52881    52826       -55     
===========================================
- Hits        48376    22102    -26274     
- Misses       4505    30724    +26219
Flag Coverage Δ
#multiple ?
#single 41.83% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/compat/__init__.py 54.83% <ø> (-5.17%) ⬇️
pandas/io/common.py 43.79% <0%> (-29.07%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.36%) ⬇️
pandas/io/formats/excel.py 14.93% <100%> (-82.47%) ⬇️
pandas/core/computation/expr.py 62.84% <100%> (-25.69%) ⬇️
pandas/core/computation/common.py 65% <100%> (-24.48%) ⬇️
pandas/util/_test_decorators.py 88.23% <100%> (-2.31%) ⬇️
pandas/core/internals/construction.py 64.61% <100%> (-31.3%) ⬇️
pandas/core/indexes/range.py 52.58% <100%> (-44.83%) ⬇️
pandas/util/testing.py 50.26% <50%> (-39.48%) ⬇️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c6a05...de77267. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #25873 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25873      +/-   ##
==========================================
+ Coverage   91.47%   91.53%   +0.06%     
==========================================
  Files         175      175              
  Lines       52863    52808      -55     
==========================================
- Hits        48357    48339      -18     
+ Misses       4506     4469      -37
Flag Coverage Δ
#multiple 90.09% <100%> (+0.05%) ⬆️
#single 41.82% <82.6%> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/compat/__init__.py 65.59% <ø> (+5.59%) ⬆️
pandas/io/formats/excel.py 97.4% <100%> (ø) ⬆️
pandas/core/computation/expr.py 88.52% <100%> (ø) ⬆️
pandas/io/common.py 72.86% <100%> (ø) ⬆️
pandas/util/testing.py 90.56% <100%> (+0.83%) ⬆️
pandas/core/computation/common.py 90% <100%> (+0.52%) ⬆️
pandas/io/formats/html.py 99.35% <100%> (ø) ⬆️
pandas/util/_test_decorators.py 92.64% <100%> (+2.1%) ⬆️
pandas/core/internals/construction.py 95.89% <100%> (-0.02%) ⬇️
pandas/core/indexes/range.py 97.41% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac318d2...022699e. Read the comment docs.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice job!

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you can move the indicated imports to the top. ping on green.

@jschendel
Copy link
Member Author

@jreback: green

@jreback
Copy link
Contributor

jreback commented Mar 27, 2019

can you merge master. lgtm. merge on green.

@gfyoung gfyoung merged commit 882961d into pandas-dev:master Mar 27, 2019
@gfyoung
Copy link
Member

gfyoung commented Mar 27, 2019

Thanks @jschendel !

@jschendel jschendel deleted the remove-compat-misc branch March 28, 2019 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants