-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Remove miscellaneous rarely used items from pandas.compat #25873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25873 +/- ##
===========================================
- Coverage 91.48% 41.83% -49.65%
===========================================
Files 175 175
Lines 52881 52826 -55
===========================================
- Hits 48376 22102 -26274
- Misses 4505 30724 +26219
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25873 +/- ##
==========================================
+ Coverage 91.47% 91.53% +0.06%
==========================================
Files 175 175
Lines 52863 52808 -55
==========================================
- Hits 48357 48339 -18
+ Misses 4506 4469 -37
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you can move the indicated imports to the top. ping on green.
@jreback: green |
can you merge master. lgtm. merge on green. |
Thanks @jschendel ! |
git diff upstream/master -u -- "*.py" | flake8 --diff
Gets rid of the following from
pandas.compat
:intern
reduce
unichr
wraps
get_range_parameters
class_types
reload
set_defaultencoding
as it usedreload
, was never used, and is PY2 specificimport_lzma
skip_if_no_lzma
sincelzma
is in the standard library for PY3