Skip to content

CLN: Remove vestigial references to PY2 in tests #25865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Mar 25, 2019

xref #25725

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite 2/3 Compat Clean labels Mar 25, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone Mar 25, 2019
@gfyoung gfyoung force-pushed the tests-py2-cleanup branch from faf1f04 to 7317a79 Compare March 25, 2019 01:23
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #25865 into master will decrease coverage by 49.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #25865       +/-   ##
===========================================
- Coverage   91.47%   41.82%   -49.66%     
===========================================
  Files         173      173               
  Lines       52872    52872               
===========================================
- Hits        48366    22112    -26254     
- Misses       4506    30760    +26254
Flag Coverage Δ
#multiple ?
#single 41.82% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.36%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
pandas/io/json/normalize.py 8.16% <0%> (-88.78%) ⬇️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9821b77...7317a79. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #25865 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25865   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         173      173           
  Lines       52872    52872           
=======================================
  Hits        48366    48366           
  Misses       4506     4506
Flag Coverage Δ
#multiple 90.04% <ø> (ø) ⬆️
#single 41.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9821b77...649f6ce. Read the comment docs.

@gfyoung gfyoung force-pushed the tests-py2-cleanup branch from 7317a79 to 649f6ce Compare March 25, 2019 04:27
@jreback jreback merged commit 758187f into pandas-dev:master Mar 25, 2019
@jreback
Copy link
Contributor

jreback commented Mar 25, 2019

thanks @gfyoung

@gfyoung gfyoung deleted the tests-py2-cleanup branch March 25, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants