Skip to content

CLN: Remove long and integer_types from pandas.compat #25862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2019

Conversation

jschendel
Copy link
Member

Another incremental step in removing Python 2. Doesn't look like integer_types was actually used anywhere. Otherwise mostly long --> int, or just removing long as the argument was already an int in Python 3.

@jschendel jschendel added Numeric Operations Arithmetic, Comparison, and Logical operations 2/3 Compat Clean labels Mar 24, 2019
@jschendel jschendel added this to the 0.25.0 milestone Mar 24, 2019
@jreback
Copy link
Contributor

jreback commented Mar 24, 2019

lgtm. merge on green.

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #25862 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25862      +/-   ##
==========================================
+ Coverage   91.47%   91.47%   +<.01%     
==========================================
  Files         173      173              
  Lines       52872    52868       -4     
==========================================
- Hits        48364    48362       -2     
+ Misses       4508     4506       -2
Flag Coverage Δ
#multiple 90.04% <100%> (ø) ⬆️
#single 41.82% <33.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 60% <ø> (+0.17%) ⬆️
pandas/core/internals/blocks.py 94.08% <ø> (ø) ⬆️
pandas/io/json/json.py 93.22% <100%> (ø) ⬆️
pandas/core/sorting.py 98.29% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2618b21...18422e3. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #25862 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25862      +/-   ##
==========================================
+ Coverage   91.47%   91.47%   +<.01%     
==========================================
  Files         173      173              
  Lines       52872    52868       -4     
==========================================
- Hits        48364    48362       -2     
+ Misses       4508     4506       -2
Flag Coverage Δ
#multiple 90.04% <100%> (ø) ⬆️
#single 41.82% <33.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 60% <ø> (+0.17%) ⬆️
pandas/core/internals/blocks.py 94.08% <ø> (ø) ⬆️
pandas/io/json/json.py 93.22% <100%> (ø) ⬆️
pandas/core/sorting.py 98.29% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2618b21...18422e3. Read the comment docs.

@jschendel jschendel merged commit dca809b into pandas-dev:master Mar 24, 2019
@jschendel jschendel deleted the remove-compat-long branch March 24, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants