[REF] Move remaining locale functions to _config.localization #25861
Conversation
|
Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-03-25 13:55:53 UTC |
| """ | ||
| global _initial_defencoding | ||
|
|
||
| encoding = None |
There was a problem hiding this comment.
shouldn’t u check the global first? (if it’s set)
There was a problem hiding this comment.
The comment near the bottom suggests this is kept for debugging purposes related to matplotlib
pandas/_config/display.py
Outdated
| """ | ||
|
|
||
| pc_date_yearfirst_doc = """ | ||
| : boolean |
There was a problem hiding this comment.
these are pretty orthogonal right ?
There was a problem hiding this comment.
Yes. Handling dayfirst and yearfirst finishes breaking the reliance of tslibs on core.
There was a problem hiding this comment.
right but they shouldn't be in this file. not problem separateing them out, but not here
There was a problem hiding this comment.
they're under the display namespace within options. where would you put this? could go directly at the bottom of __init__ i guess
There was a problem hiding this comment.
i would put them in another file under _config
Codecov Report
@@ Coverage Diff @@
## master #25861 +/- ##
==========================================
+ Coverage 91.47% 91.47% +<.01%
==========================================
Files 173 174 +1
Lines 52872 52876 +4
==========================================
+ Hits 48364 48369 +5
+ Misses 4508 4507 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25861 +/- ##
==========================================
+ Coverage 91.47% 91.48% +<.01%
==========================================
Files 173 175 +2
Lines 52872 52877 +5
==========================================
+ Hits 48367 48372 +5
Misses 4505 4505
Continue to review full report at Codecov.
|
gfyoung
added
Refactor
|
thanks @jbrockmendel |
There are a a couple locale-centric functions left in
tmthat have not yet been moved because they depend onpd.options.display.encoding. This PR implements a minimal_config.displaythat allows us to consolidate the locale functions._config.displayalso definesdisplay.date_dayfirstanddisplay.date_yearfirst, since those are used bytslibs.parsing. So this completes the process of removingtslib's dependency oncore.The existing
get_localesfunction has aif PY3check that is no longer necessary, so this removes the PY2 branch of that.