Skip to content

Remove chainmap_impl compat code #25840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

Also avoid having a dependency in compat on core.

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #25840 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25840      +/-   ##
==========================================
+ Coverage    91.3%   91.44%   +0.13%     
==========================================
  Files         173      172       -1     
  Lines       53004    52922      -82     
==========================================
- Hits        48397    48395       -2     
+ Misses       4607     4527      -80
Flag Coverage Δ
#multiple 90.01% <100%> (+0.13%) ⬆️
#single 41.83% <100%> (+0.06%) ⬆️
Impacted Files Coverage Δ
pandas/compat/chainmap.py 66.66% <100%> (+4.76%) ⬆️
pandas/compat/numpy/function.py 87.91% <100%> (ø) ⬆️
pandas/util/testing.py 89.3% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3e0e6...7b61159. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #25840 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25840      +/-   ##
==========================================
+ Coverage    91.3%   91.44%   +0.13%     
==========================================
  Files         173      172       -1     
  Lines       53004    52922      -82     
==========================================
- Hits        48397    48395       -2     
+ Misses       4607     4527      -80
Flag Coverage Δ
#multiple 90.01% <100%> (+0.13%) ⬆️
#single 41.83% <100%> (+0.06%) ⬆️
Impacted Files Coverage Δ
pandas/compat/chainmap.py 66.66% <100%> (+4.76%) ⬆️
pandas/compat/numpy/function.py 87.91% <100%> (ø) ⬆️
pandas/util/testing.py 89.3% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3e0e6...7b61159. Read the comment docs.

@jreback jreback added the Clean label Mar 23, 2019
@jreback jreback added this to the 0.25.0 milestone Mar 23, 2019
@jreback jreback merged commit 2b67692 into pandas-dev:master Mar 23, 2019
@jreback
Copy link
Contributor

jreback commented Mar 23, 2019

thanks!

@jbrockmendel jbrockmendel deleted the clndeps branch March 23, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants