TST: Remove compat.PY2 and compat.PY3 flags from tests #25817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #25817 +/- ##
==========================================
+ Coverage 91.27% 91.27% +<.01%
==========================================
Files 173 173
Lines 53002 53002
==========================================
+ Hits 48375 48376 +1
+ Misses 4627 4626 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25817 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 173 173
Lines 53002 53002
=======================================
Hits 48375 48375
Misses 4627 4627
Continue to review full report at Codecov.
|
jschendel
force-pushed
the
remove-py2-py3-flags
branch
from
3695aed to
4a2ac83
Compare
|
thanks @jschendel that's what I like, -1000 lines! |
|
keep em coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThese flags become trivial after dropping Python 2. There are still some Python 2 specific things that can be removed from the tests but this should eliminate a lot of the low hanging fruit.
Can split this up into separate PRs if need be; there are lots of changes but they're of low complexity and disjoint from each other, so shouldn't be too bad to review. Can wait on the other PRs mentioned in the master tracker issue if we want those to go in first.