Move core.config to _config.config #25793

jbrockmendel · 2019-03-20T02:04:38Z

and update imports. Move tests.test_config to tests.config.test_config.

Following this there will be one more follow-up that will 1) address the TODO in tests.config.test_localization, 2) fully disentangle tslibs from its dependency on core.

pandas/_config/__init__.py

pandas/tests/sparse/test_format.py

codecov · 2019-03-20T02:38:59Z

Codecov Report

Merging #25793 into master will increase coverage by <.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master   #25793      +/-   ##
==========================================
+ Coverage   91.26%   91.26%   +<.01%     
==========================================
  Files         173      174       +1     
  Lines       52982    52984       +2     
==========================================
+ Hits        48355    48357       +2     
  Misses       4627     4627

Flag	Coverage Δ
#multiple	`89.83% <92.85%> (ø)`	⬆️
#single	`41.76% <82.14%> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/_config/config.py	`86.82% <ø> (ø)`
pandas/core/api.py	`100% <ø> (ø)`	⬆️
pandas/core/dtypes/dtypes.py	`96.1% <0%> (ø)`	⬆️
pandas/io/formats/console.py	`86.27% <0%> (ø)`	⬆️
pandas/core/computation/expressions.py	`93.27% <100%> (ø)`	⬆️
pandas/core/indexes/multi.py	`95.62% <100%> (ø)`	⬆️
pandas/io/formats/format.py	`97.99% <100%> (ø)`	⬆️
pandas/core/base.py	`97.76% <100%> (ø)`	⬆️
pandas/plotting/_core.py	`83.65% <100%> (ø)`	⬆️
pandas/io/formats/html.py	`99.35% <100%> (ø)`	⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb11912...0e28708. Read the comment docs.

codecov · 2019-03-20T02:38:59Z

Codecov Report

Merging #25793 into master will increase coverage by <.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master   #25793      +/-   ##
==========================================
+ Coverage   91.47%   91.47%   +<.01%     
==========================================
  Files         172      173       +1     
  Lines       52870    52872       +2     
==========================================
+ Hits        48362    48364       +2     
  Misses       4508     4508

Flag	Coverage Δ
#multiple	`90.03% <92.85%> (ø)`	⬆️
#single	`41.82% <82.14%> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/_config/config.py	`86.82% <ø> (ø)`
pandas/core/api.py	`100% <ø> (ø)`	⬆️
pandas/core/dtypes/dtypes.py	`96.1% <0%> (ø)`	⬆️
pandas/io/formats/console.py	`86.27% <0%> (ø)`	⬆️
pandas/core/computation/expressions.py	`93.27% <100%> (ø)`	⬆️
pandas/core/indexes/multi.py	`95.62% <100%> (ø)`	⬆️
pandas/io/formats/format.py	`97.99% <100%> (ø)`	⬆️
pandas/core/base.py	`97.76% <100%> (ø)`	⬆️
pandas/plotting/_core.py	`83.65% <100%> (ø)`	⬆️
pandas/io/formats/html.py	`99.35% <100%> (ø)`	⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5a7e3...8655437. Read the comment docs.

…stream3

jreback · 2019-03-20T12:18:11Z

ImportError while importing test module 'D:\a\1\s\pandas\tests\sparse\test_format.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
pandas\tests\sparse\test_format.py:9: in <module>
    from pandas.core.config import option_context
E   ModuleNotFoundError: No module named 'pandas.core.config'
============================== warnings summary ================

…stream3

jbrockmendel · 2019-03-20T16:37:29Z

Fixed

jreback · 2019-03-22T11:40:26Z

can you rebase

…stream3

jbrockmendel · 2019-03-22T15:30:59Z

rebased+green

jreback · 2019-03-22T16:27:23Z

pandas/_libs/tslibs/parsing.pyx

@@ -30,6 +30,8 @@ from dateutil.relativedelta import relativedelta
 from dateutil.parser import DEFAULTPARSER
 from dateutil.parser import parse as du_parse

+from pandas._config.config import get_option


rather than reaching in, I would expose get_options, and company in pandas._config (in the 'all')?

…stream3

pep8speaks · 2019-03-22T17:48:15Z

Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-24 15:48:29 UTC

jreback · 2019-03-22T19:45:49Z

pandas/__init__.py

@@ -36,6 +36,9 @@

 from datetime import datetime

+from pandas._config.config import (get_option, set_option, reset_option,


what I mean was to have all of these listed in the 'all' in pandas._config, then this can just be a * import and then you can always just from pandas._config import ..... rather than reaching into pandas._config.config (I know there are some cases of that but can fix those in a follow). this would make clear then this modules public api.

OK. Moved those into _config.__init__. Will update all the other imports on the next pass. Will ignore the "*" import idea.

Will ignore the "*" import idea.

we do this for all api imports in pandas/init.py

... for now.

…stream3

jreback

needs a rebase. pls try to normalize all of the imports to import from pandas if at all possible (which should be fore all except: import pandas._config.config as cf which is used occasionally (want to clean those up too but can be a followup)

jreback · 2019-03-23T20:32:05Z

pandas/tests/indexes/multi/test_format.py

@@ -54,7 +54,7 @@ def test_format_sparse_display():


 def test_repr_with_unicode_data():
-    with pd.core.config.option_context("display.encoding", 'UTF-8'):
+    with pd._config.config.option_context("display.encoding", 'UTF-8'):


can you just import option_context at the top

jreback · 2019-03-23T20:32:37Z

pandas/tests/sparse/test_format.py

@@ -3,10 +3,11 @@

 import numpy as np

+from pandas._config.config import option_context


would prefer you import from pandas directly (and all cases where it is possible)

…stream3

jreback · 2019-03-24T15:36:27Z

sorry, can you rebase again :< looks good otherwise.

…stream3

jreback · 2019-03-24T18:14:56Z

pandas/__init__.py

@@ -36,6 +36,9 @@

 from datetime import datetime

+from pandas._config import (get_option, set_option, reset_option,


how did these get in here now? (Ithink it is explicit and ok), but just wondering

These used to be a "*" import, now made explicit.

jreback · 2019-03-24T18:34:14Z

thanks @jbrockmendel

jbrockmendel added 2 commits March 19, 2019 18:49

move core.config to _config.config, update imports

fda71de

isort imports

0e28708

jreback requested changes Mar 20, 2019

View reviewed changes

pandas/_config/__init__.py Outdated Show resolved Hide resolved

pandas/tests/sparse/test_format.py Outdated Show resolved Hide resolved

jreback added the Clean label Mar 20, 2019

jbrockmendel added 3 commits March 19, 2019 21:06

restore accidnetally-deleted file

a4c8e6d

Merge branch 'master' of https://github.com/pandas-dev/pandas into up…

c1c62a7

…stream3

Change to absolute import

7164f61

jbrockmendel added 2 commits March 20, 2019 08:18

Merge branch 'master' of https://github.com/pandas-dev/pandas into up…

005673f

…stream3

update import

c531c0c

jreback added this to the 0.25.0 milestone Mar 22, 2019

Merge branch 'master' of https://github.com/pandas-dev/pandas into up…

617fa3d

…stream3

jreback reviewed Mar 22, 2019

View reviewed changes

jbrockmendel added 3 commits March 22, 2019 10:02

Merge branch 'master' of https://github.com/pandas-dev/pandas into up…

7b86e13

…stream3

update imports

c271fd6

fixup import

d82c15d

flake8 fixup

11a7117

jreback reviewed Mar 22, 2019

View reviewed changes

jbrockmendel added 2 commits March 22, 2019 12:52

Merge branch 'master' of https://github.com/pandas-dev/pandas into up…

178a836

…stream3

put more in __all__

78dc045

jreback requested changes Mar 23, 2019

View reviewed changes

jbrockmendel added 3 commits March 23, 2019 14:39

Merge branch 'master' of https://github.com/pandas-dev/pandas into up…

78c9964

…stream3

update imports in tests

62b01fb

update import

3325949

Merge branch 'master' of https://github.com/pandas-dev/pandas into up…

8655437

…stream3

jreback approved these changes Mar 24, 2019

View reviewed changes

jreback reviewed Mar 24, 2019

View reviewed changes

jreback merged commit 2618b21 into pandas-dev:master Mar 24, 2019

jbrockmendel deleted the upstream3 branch March 24, 2019 18:35

huandzh mentioned this pull request Jul 23, 2019

Fix PandasOptionError import. aliyun/aliyun-odps-python-sdk#99

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move core.config to _config.config #25793

Move core.config to _config.config #25793

jbrockmendel commented Mar 20, 2019

codecov bot commented Mar 20, 2019

codecov bot commented Mar 20, 2019 •

edited

Loading

jreback commented Mar 20, 2019

jbrockmendel commented Mar 20, 2019

jreback commented Mar 22, 2019

jbrockmendel commented Mar 22, 2019

jreback Mar 22, 2019

pep8speaks commented Mar 22, 2019 •

edited

Loading

jreback Mar 22, 2019

jbrockmendel Mar 22, 2019

jreback Mar 22, 2019

jbrockmendel Mar 22, 2019

jreback left a comment

jreback Mar 23, 2019

jreback Mar 23, 2019

jreback commented Mar 24, 2019 •

edited

Loading

jreback Mar 24, 2019

jbrockmendel Mar 24, 2019

jreback commented Mar 24, 2019

		@@ -36,6 +36,9 @@

		from datetime import datetime

		from pandas._config.config import (get_option, set_option, reset_option,

		@@ -3,10 +3,11 @@

		import numpy as np

		from pandas._config.config import option_context

		@@ -36,6 +36,9 @@

		from datetime import datetime

		from pandas._config import (get_option, set_option, reset_option,

Move core.config to _config.config #25793

Move core.config to _config.config #25793

Conversation

jbrockmendel commented Mar 20, 2019

codecov bot commented Mar 20, 2019

Codecov Report

codecov bot commented Mar 20, 2019 • edited Loading

Codecov Report

jreback commented Mar 20, 2019

jbrockmendel commented Mar 20, 2019

jreback commented Mar 22, 2019

jbrockmendel commented Mar 22, 2019

Choose a reason for hiding this comment

pep8speaks commented Mar 22, 2019 • edited Loading

Comment last updated at 2019-03-24 15:48:29 UTC

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Mar 24, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Mar 24, 2019

codecov bot commented Mar 20, 2019 •

edited

Loading

pep8speaks commented Mar 22, 2019 •

edited

Loading

jreback commented Mar 24, 2019 •

edited

Loading