[WIP] STY: activate pytest.raises context manager code check #25750

simonjayhawkins · 2019-03-17T10:46:43Z

pandas/tests/arrays/sparse/test_libsparse.py
pandas/tests/computation/test_eval.py
pandas/tests/frame/test_nonunique_indexes.py
pandas/tests/indexes/interval/test_interval_new.py
pandas/tests/indexing/multiindex/test_partial.py
pandas/tests/indexing/test_floats.py: seperate PR TST: indexing/test_floats.py::TestFloatIndexers::test_scalar_non_numeric #25748
pandas/tests/io/test_pytables.py: tbc once TST: Split out test_pytables.py to sub-module of tests #25004 is merged
pandas/tests/series/test_constructors.py

pandas/tests/arrays/sparse/test_libsparse.py

simonjayhawkins · 2019-03-17T11:03:52Z

pandas/tests/computation/test_eval.py

-            pytest.raises(AssertionError, tm.assert_numpy_array_equal,
-                          result, expected)
+            with pytest.raises(AssertionError):
+                tm.assert_numpy_array_equal(result, expected)


didn't convert this on first pass since test is skipped on windows. looking at it again, the assertion error check is used in lieu of a tm.assert_numpy_array_not_equal function so message check not appropriate.

simonjayhawkins · 2019-03-17T11:04:50Z

pandas/tests/series/test_constructors.py

        # for t in ['s', 'D', 'us', 'ms']:
-        #    pytest.raises(TypeError, td.astype, 'm8[%s]' % t)
+        #     with pytest.raises(TypeError, match="<enter message here>"):
+        #         td.astype('m8[%s]' % t)


does not raise. added a TODO. not in this PR though.

simonjayhawkins · 2019-03-17T11:04:55Z

pandas/tests/frame/test_nonunique_indexes.py

-        pytest.raises(Exception, lambda x: DataFrame(
-            [[1, 2, 'foo', 'bar']], columns=['a', 'a', 'a', 'a']))
+        # with pytest.raises(Exception, match="<enter message here>"):
+        #     DataFrame([[1, 2, 'foo', 'bar']], columns=['a', 'a', 'a', 'a'])


does not raise. added a TODO. not in this PR though.

Was this not failing CI before?

@WillAyd . case of lambda x: with no x raises TypeError and so passed CI.

simonjayhawkins · 2019-03-17T11:05:50Z

pandas/tests/indexes/interval/test_interval_new.py

@@ -6,6 +6,7 @@
 from pandas import Int64Index, Interval, IntervalIndex
 import pandas.util.testing as tm

+# TODO: unskip these tests and enter error messages for pytest.raises


this whole module is skipped. added a TODO. not in this PR though.

simonjayhawkins · 2019-03-17T11:07:32Z

pandas/tests/indexing/multiindex/test_partial.py

@@ -134,21 +134,23 @@ def test_partial_set(

    def test_partial_ix_missing(
            self, multiindex_year_month_day_dataframe_random_data):
-        pytest.skip("skipping for now")
+        pytest.skip("skipping for now")  # TODO: fix this


this test is skipped. added a TODO. not in this PR though.

codecov · 2019-03-17T11:32:53Z

Codecov Report

Merging #25750 into master will decrease coverage by 49.5%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #25750       +/-   ##
===========================================
- Coverage   91.25%   41.74%   -49.51%     
===========================================
  Files         172      172               
  Lines       52977    52977               
===========================================
- Hits        48343    22117    -26226     
- Misses       4634    30860    +26226

Flag	Coverage Δ
#multiple	`?`
#single	`41.74% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/io/formats/latex.py	`0% <0%> (-100%)`	⬇️
pandas/io/sas/sas_constants.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/plotting.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/converter.py	`0% <0%> (-100%)`	⬇️
pandas/io/formats/html.py	`0% <0%> (-99.36%)`	⬇️
pandas/core/groupby/categorical.py	`0% <0%> (-95.46%)`	⬇️
pandas/io/sas/sas7bdat.py	`0% <0%> (-91.17%)`	⬇️
pandas/io/sas/sas_xport.py	`0% <0%> (-90.15%)`	⬇️
pandas/core/tools/numeric.py	`10.44% <0%> (-89.56%)`	⬇️
pandas/io/json/normalize.py	`8.16% <0%> (-88.78%)`	⬇️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c0441...472e375. Read the comment docs.

codecov · 2019-03-17T11:32:53Z

Codecov Report

Merging #25750 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25750      +/-   ##
==========================================
- Coverage   91.25%   91.25%   -0.01%     
==========================================
  Files         172      172              
  Lines       52977    52977              
==========================================
- Hits        48343    48342       -1     
- Misses       4634     4635       +1

Flag	Coverage Δ
#multiple	`89.82% <ø> (ø)`	⬆️
#single	`41.74% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	`88.98% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c0441...472e375. Read the comment docs.

WillAyd

Just so I am clear the PRs you link to in the OP are pre-cursors to this correct?

WillAyd · 2019-03-18T03:54:13Z

pandas/tests/frame/test_nonunique_indexes.py

-        pytest.raises(Exception, lambda x: DataFrame(
-            [[1, 2, 'foo', 'bar']], columns=['a', 'a', 'a', 'a']))
+        # with pytest.raises(Exception, match="<enter message here>"):
+        #     DataFrame([[1, 2, 'foo', 'bar']], columns=['a', 'a', 'a', 'a'])


Was this not failing CI before?

simonjayhawkins · 2019-03-18T08:23:25Z

Just so I am clear the PRs you link to in the OP are pre-cursors to this correct?

not necessarily. Holding off pytables conversion to avoid overlapping PRs but this could be done now. The other PR is more than required to activate the code check so the minimum change could be added here.

jreback · 2019-03-26T00:23:05Z

superseded by #25866

simonjayhawkins added 2 commits March 17, 2019 10:34

activate context manager code check

1c4723f

Merge remote-tracking branch 'upstream/master' into cm-wip

f12eb4c

simonjayhawkins commented Mar 17, 2019

View reviewed changes

simonjayhawkins added 2 commits March 17, 2019 11:19

remove code check TODO message

2cfb06d

update message for test skipped on windows

472e375

simonjayhawkins mentioned this pull request Mar 17, 2019

TST: indexing/test_floats.py::TestFloatIndexers::test_scalar_non_numeric #25748

Closed

WillAyd reviewed Mar 18, 2019

View reviewed changes

WillAyd added Testing pandas testing functions or related to the test suite Code Style Code style, linting, code_checks labels Mar 18, 2019

jreback closed this Mar 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] STY: activate pytest.raises context manager code check #25750

[WIP] STY: activate pytest.raises context manager code check #25750

simonjayhawkins commented Mar 17, 2019 •

edited

Loading

simonjayhawkins Mar 17, 2019

simonjayhawkins Mar 17, 2019

simonjayhawkins Mar 17, 2019

WillAyd Mar 18, 2019

simonjayhawkins Mar 18, 2019

simonjayhawkins Mar 17, 2019

simonjayhawkins Mar 17, 2019

codecov bot commented Mar 17, 2019

codecov bot commented Mar 17, 2019 •

edited

Loading

WillAyd left a comment

WillAyd Mar 18, 2019

simonjayhawkins commented Mar 18, 2019

jreback commented Mar 26, 2019

[WIP] STY: activate pytest.raises context manager code check #25750

[WIP] STY: activate pytest.raises context manager code check #25750

Conversation

simonjayhawkins commented Mar 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Mar 17, 2019

Codecov Report

codecov bot commented Mar 17, 2019 • edited Loading

Codecov Report

WillAyd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simonjayhawkins commented Mar 18, 2019

jreback commented Mar 26, 2019

simonjayhawkins commented Mar 17, 2019 •

edited

Loading

codecov bot commented Mar 17, 2019 •

edited

Loading