Skip to content

Backport PR #25651 on branch 0.24.x (REGR: to_timedelta precision issues with floating data) #25687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25651: REGR: to_timedelta precision issues with floating data

@lumberbot-app lumberbot-app bot added this to the 0.24.2 milestone Mar 12, 2019
@jreback jreback added the Timedelta Timedelta data type label Mar 12, 2019
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #25687 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25687      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52424    52428       +4     
==========================================
+ Hits        48437    48441       +4     
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.83% <100%> (ø) ⬆️
#single 42.9% <83.33%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/timedeltas.py 88.29% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef1dd8...dc66c9b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #25687 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25687      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52424    52428       +4     
==========================================
+ Hits        48437    48441       +4     
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.83% <100%> (ø) ⬆️
#single 42.9% <83.33%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/timedeltas.py 88.29% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef1dd8...dc66c9b. Read the comment docs.

@jreback jreback merged commit c53c9d1 into pandas-dev:0.24.x Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants