Skip to content

DOC: clean-up of 0.24.2 whatsnew file #25660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jorisvandenbossche
Copy link
Member

No description provided.

@jorisvandenbossche jorisvandenbossche added this to the 0.24.2 milestone Mar 11, 2019
@jreback
Copy link
Contributor

jreback commented Mar 11, 2019

a more general comment. I find the 'Fixed Regressions' section way harder to read than our separated Bug Fixes section (e.g. by area). Ideally should either reorg that and have sub-topics, or just combine them to one (maybe have a way of flagging a regression vs a bug).

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Mar 11, 2019 via email

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25660 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25660   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         173      173           
  Lines       52961    52961           
=======================================
  Hits        48350    48350           
  Misses       4611     4611
Flag Coverage Δ
#multiple 89.86% <ø> (ø) ⬆️
#single 41.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fa3c9...a7d5890. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25660 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25660      +/-   ##
==========================================
+ Coverage   91.29%   91.29%   +<.01%     
==========================================
  Files         173      173              
  Lines       52961    52961              
==========================================
+ Hits        48349    48350       +1     
+ Misses       4612     4611       -1
Flag Coverage Δ
#multiple 89.86% <ø> (ø) ⬆️
#single 41.73% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 89.08% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21769e9...10b3a8d. Read the comment docs.

@jorisvandenbossche
Copy link
Member Author

I personally like the separate regressions section, but they indeed could also be subdivided (the labels of sklearn are also nice, but they group everything (also enhancements) per topic).
But given that this PR was only cleaning up the whitespace for what is already there, going to leave that discussion for another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants