Skip to content

BUG: Preserve name in DatetimeIndex.snap #25585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2019
Merged

BUG: Preserve name in DatetimeIndex.snap #25585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
591f47f
Use self.name to construct the result of `DatetimeIndex.snap`, fix #2…
sighingnow Mar 7, 2019
457d0b6
Move to 0.25.0, handle `tz` correctly and revise test case.
sighingnow Mar 12, 2019
cf1312c
Parametrize the test case.
sighingnow Mar 12, 2019
b169fa8
Ignore deprecationwarning in `DatetimeIndex.snap`, fix CI.
sighingnow Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.25.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Other API Changes
- :class:`DatetimeTZDtype` will now standardize pytz timezones to a common timezone instance (:issue:`24713`)
- ``Timestamp`` and ``Timedelta`` scalars now implement the :meth:`to_numpy` method as aliases to :meth:`Timestamp.to_datetime64` and :meth:`Timedelta.to_timedelta64`, respectively. (:issue:`24653`)
- :meth:`Timestamp.strptime` will now rise a ``NotImplementedError`` (:issue:`25016`)
-
- Bug in :meth:`DatetimeIndex.snap` which didn't preserving the ``name`` of the input :class:`Index` (:issue:`25575`)

.. _whatsnew_0250.deprecations:

Expand Down
4 changes: 2 additions & 2 deletions pandas/core/indexes/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,8 +787,8 @@ def snap(self, freq='S'):
snapped[i] = s

# we know it conforms; skip check
return DatetimeIndex._simple_new(snapped, freq=freq)
# TODO: what about self.name? tz? if so, use shallow_copy?
return DatetimeIndex._simple_new(snapped, name=self.name, tz=self.tz,
freq=freq)

def join(self, other, how='left', level=None, return_indexers=False,
sort=False):
Expand Down
28 changes: 18 additions & 10 deletions pandas/tests/series/indexing/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,28 @@ def test_fancy_setitem():
assert (s[48:54] == -3).all()


def test_dti_snap():
@pytest.mark.filterwarnings("ignore::DeprecationWarning")
@pytest.mark.parametrize('tz', [None, 'Asia/Shanghai', 'Europe/Berlin'])
@pytest.mark.parametrize('name', [None, 'my_dti'])
def test_dti_snap(name, tz):
dti = DatetimeIndex(['1/1/2002', '1/2/2002', '1/3/2002', '1/4/2002',
'1/5/2002', '1/6/2002', '1/7/2002'], freq='D')
'1/5/2002', '1/6/2002', '1/7/2002'],
name=name, tz=tz, freq='D')

res = dti.snap(freq='W-MON')
exp = date_range('12/31/2001', '1/7/2002', freq='w-mon')
exp = exp.repeat([3, 4])
assert (res == exp).all()
result = dti.snap(freq='W-MON')
expected = date_range('12/31/2001', '1/7/2002',
name=name, tz=tz, freq='w-mon')
expected = expected.repeat([3, 4])
tm.assert_index_equal(result, expected)
assert result.tz == expected.tz

res = dti.snap(freq='B')
result = dti.snap(freq='B')

exp = date_range('1/1/2002', '1/7/2002', freq='b')
exp = exp.repeat([1, 1, 1, 2, 2])
assert (res == exp).all()
expected = date_range('1/1/2002', '1/7/2002',
name=name, tz=tz, freq='b')
expected = expected.repeat([1, 1, 1, 2, 2])
tm.assert_index_equal(result, expected)
assert result.tz == expected.tz


def test_dti_reset_index_round_trip():
Expand Down