Skip to content

Backport PR #25368 on branch 0.24.x (BUG: Fix potential segfault after pd.Categorical(pd.Series(...), categories=...)) #25520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25368: BUG: Fix potential segfault after pd.Categorical(pd.Series(...), categories=...)

@lumberbot-app lumberbot-app bot added this to the 0.24.2 milestone Mar 3, 2019
@jreback jreback added Bug Categorical Categorical Data Type labels Mar 3, 2019
@jreback jreback merged commit 969ca46 into pandas-dev:0.24.x Mar 3, 2019
@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #25520 into 0.24.x will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25520      +/-   ##
==========================================
- Coverage   92.39%   92.39%   -0.01%     
==========================================
  Files         166      166              
  Lines       52421    52419       -2     
==========================================
- Hits        48434    48432       -2     
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.83% <100%> (-0.01%) ⬇️
#single 42.91% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.96% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03fe61d...e6fee8e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #25520 into 0.24.x will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25520      +/-   ##
==========================================
- Coverage   92.39%   92.39%   -0.01%     
==========================================
  Files         166      166              
  Lines       52421    52419       -2     
==========================================
- Hits        48434    48432       -2     
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.83% <100%> (-0.01%) ⬇️
#single 42.91% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.96% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03fe61d...e6fee8e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Categorical Categorical Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants