Skip to content

Update documentation of read_csv to explain that index_col can be a string containg a column name #25502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 15, 2019

Conversation

kimsey0
Copy link
Contributor

@kimsey0 kimsey0 commented Mar 1, 2019

Uses the suggestion from #22276 and closes #22276.

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #25502 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25502   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files         173      173           
  Lines       52955    52955           
=======================================
  Hits        48589    48589           
  Misses       4366     4366
Flag Coverage Δ
#multiple 90.32% <ø> (ø) ⬆️
#single 41.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.34% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011f0a6...c919b73. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #25502 into master will decrease coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25502      +/-   ##
==========================================
- Coverage   91.75%   91.25%   -0.51%     
==========================================
  Files         173      172       -1     
  Lines       52955    52977      +22     
==========================================
- Hits        48589    48342     -247     
- Misses       4366     4635     +269
Flag Coverage Δ
#multiple 89.82% <ø> (-0.5%) ⬇️
#single 41.74% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.34% <ø> (ø) ⬆️
pandas/core/panel.py 35.72% <0%> (-36.03%) ⬇️
pandas/core/sparse/series.py 93.3% <0%> (-2.24%) ⬇️
pandas/core/indexing.py 90.88% <0%> (-1.41%) ⬇️
pandas/core/internals/managers.py 93.92% <0%> (-0.92%) ⬇️
pandas/core/generic.py 93.51% <0%> (-0.65%) ⬇️
pandas/core/tools/datetimes.py 84.63% <0%> (-0.5%) ⬇️
pandas/io/pytables.py 90.11% <0%> (-0.09%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.06%) ⬇️
pandas/core/config.py 87% <0%> (-0.05%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011f0a6...1aa334e. Read the comment docs.

@gfyoung gfyoung added Docs IO CSV read_csv, to_csv labels Mar 2, 2019
kimsey0 added 2 commits March 3, 2019 15:11
Remove description of columns used as indexes not also being present as normal columns in documentation for read_csv.
@jreback jreback added this to the 0.25.0 milestone Mar 14, 2019
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Mar 14, 2019 via email

@kimsey0
Copy link
Contributor Author

kimsey0 commented Mar 14, 2019

Oops! I didn't notice that there's no spaces on the empty lines. It's fixed now.

@jreback
Copy link
Contributor

jreback commented Mar 14, 2019

lgtm. unless anyone has comments.

Remove description of columns used as indexes not also being present as normal columns in documentation for read_csv.
@TomAugspurger TomAugspurger merged commit 65c0441 into pandas-dev:master Mar 15, 2019
@TomAugspurger
Copy link
Contributor

Thanks @kimsey0!

@kimsey0
Copy link
Contributor Author

kimsey0 commented Mar 15, 2019

Thanks for getting it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read.csv index_col argument accepts string, list-of-string
4 participants