Draft implementation #25463
Closed
Draft implementation #25463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raises a ValueError when the input to to_datetime contains some numbers but the unit isn't supplied.
|
Hello @samuelsinayoko! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on February 27, 2019 at 20:35 Hours UTC |
gfyoung
requested review from
jreback and
mroeschke
and removed request for
jreback
|
First part of any PR should be tests so please make sure to add them. Also looks like this introduced a slew of errors so be sure to run the suite locally before pushing to GH |
|
Closing as stale - ping if you'd like to pick this back up and have tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raises a ValueError when the input to to_datetime contains some numbers
but the unit isn't supplied.
git diff upstream/master -u -- "*.py" | flake8 --diff